Commit Graph

555 Commits

Author SHA1 Message Date
Andrey Goncharov
010de365fa Allow using whole row for power search
Reviewed By: lblasa

Differential Revision: D49827828

fbshipit-source-id: 93219146ba59074be305eb9a963550223a5abd18
2023-10-02 08:27:37 -07:00
Andrey Goncharov
c27f9c7916 Fallback for empty titles
Summary: Some columns set title to an empty string

Reviewed By: lblasa

Differential Revision: D49826852

fbshipit-source-id: 3661394323dade813295420a1186d9297a8be153
2023-10-02 08:27:37 -07:00
Andrey Goncharov
84bb47655e Hide unknown value processing behind a GK
Reviewed By: antonk52

Differential Revision: D49822509

fbshipit-source-id: 2228883f8ef16013a63c0d6d69697e32b55cec68
2023-10-02 08:27:37 -07:00
Andrey Goncharov
76918ae4fe Handle unknown values when adding power search to unconfigured columns
Reviewed By: antonk52

Differential Revision: D49822513

fbshipit-source-id: a9c5c6ddc91ac6e7284af045ec673144d9c64906
2023-10-02 08:27:37 -07:00
Andrey Goncharov
4165a1b272 Handle unknown values in string operators
Reviewed By: antonk52

Differential Revision: D49822510

fbshipit-source-id: 4fc22df7af282e93af28bb0e69f70acd805e620b
2023-10-02 08:27:37 -07:00
Andrey Goncharov
8a591a7855 Support handleUnknownValues in default operators
Summary: We treat every column without the power search config as if it contains strings. Sometimes that might bite us, for instance, when the column contains an object.

Reviewed By: lblasa

Differential Revision: D49822511

fbshipit-source-id: 18dadb5abe624fae510663fc26668b2b594899c3
2023-10-02 08:27:37 -07:00
Andrey Goncharov
446147b9fe Split SimpleOperatorConfig
Reviewed By: lblasa

Differential Revision: D49822512

fbshipit-source-id: 82fc6a72cd5ff3b5f9d577baea49367b4f2521fd
2023-10-02 08:27:37 -07:00
Anton Kastritskiy
a37b04737c Move default actions and extra actions next to the search
Summary: Having default and extra actions at the bottom is not actionable. Users are used to haveing table controls on the top.

Reviewed By: LukeDefeo, aigoncharov

Differential Revision: D49538205

fbshipit-source-id: 724a31dc44de79cb0e09efae48dd2135450b34ae
2023-09-22 08:25:24 -07:00
Anton Kastritskiy
947cc819e3 remove unneccessary console.log
Reviewed By: lblasa

Differential Revision: D49502424

fbshipit-source-id: 674eb165871da43427ea5605b4aa74ec3297dd33
2023-09-21 09:43:22 -07:00
Andrey Goncharov
a35708989c Add metrics
Reviewed By: antonk52

Differential Revision: D49455605

fbshipit-source-id: 00b4de3106d2497b43708623c410ca262e931059
2023-09-20 05:39:33 -07:00
Andrey Goncharov
fc5fa4a349 Fix styles of non-interactive elements
Summary: Make non-interactive elements non-focusable and disable hover styles for them

Reviewed By: LukeDefeo

Differential Revision: D49455532

fbshipit-source-id: a047e1a149ab4131feef70b80a4995b455441701
2023-09-20 05:39:33 -07:00
Andrey Goncharov
f3bff735cc Simplify search term renderer matching
Summary: Each search term renderer handles its "editing" state internally now. As a result, we can simplify switch-case

Reviewed By: antonk52

Differential Revision: D49454252

fbshipit-source-id: 297ce73f53772b0112ed338c6aac0583f3807ec8
2023-09-20 04:36:57 -07:00
Andrey Goncharov
e031032b93 Make date term editable
Reviewed By: lblasa

Differential Revision: D49453947

fbshipit-source-id: b6959c6ac74d8966e21fb91f7dcbdf186253b93b
2023-09-20 04:36:57 -07:00
Andrey Goncharov
e180a1ed4b Make float term editable
Summary: For the purposes of the demo I added power search config for a float field to the summary field

Reviewed By: lblasa

Differential Revision: D49452844

fbshipit-source-id: 26aaadd07a1a8a67dfcf3cb9d8e487f8f4ee2214
2023-09-20 04:36:57 -07:00
Andrey Goncharov
31e93ff3fe Make integer term editable
Summary: For the purposes of the demo I added power search config for an integer field to the summary field

Reviewed By: lblasa

Differential Revision: D49452729

fbshipit-source-id: 78b8fdccfd799a0f71f652d90d10e11db237cbae
2023-09-20 04:36:57 -07:00
Andrey Goncharov
b3fe4c9650 Make enum term editable
Reviewed By: lblasa

Differential Revision: D49452483

fbshipit-source-id: e9bef3c5499a91231f6025e403c132b924491def
2023-09-20 04:36:57 -07:00
Andrey Goncharov
09cb48a3e3 Make string term editable
Summary:
At the end of the stack we are going to unify two branches of the switch-case in PowerSearchTerm.tsx.
Each search term is going to handle the finalized and "editing" mode internally

Reviewed By: lblasa

Differential Revision: D49451975

fbshipit-source-id: 587ba332d1fbfbaefb368e37965543575e64062f
2023-09-20 04:36:57 -07:00
Andrey Goncharov
1163769b83 Change layout for power search enabled data table
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49411939

fbshipit-source-id: 0ca8b69ac7eaad1ece88caa5a220203fe54ad946
2023-09-19 08:19:25 -07:00
Andrey Goncharov
f6ffbfe3e2 Fix filtering bugs
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49411941

fbshipit-source-id: 530b0abcbba57e2503da4641d17fd1a507955b45
2023-09-19 08:19:25 -07:00
Andrey Goncharov
6f38ecfd01 Add enum_is_nullish_or operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410975

fbshipit-source-id: 5f97e055107dfb72d14825b5d697cea71b9bf81a
2023-09-19 08:19:25 -07:00
Andrey Goncharov
e6f1e7a74f Add enum_set_is_nullish_or_any_of operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410967

fbshipit-source-id: 699e620ce1076793597702711758809fc149389e
2023-09-19 08:19:25 -07:00
Andrey Goncharov
a6fdc127a2 Simplify SearchTerm
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410971

fbshipit-source-id: 5651dd1745aaf2efc96bae6a6b36cadad00d5c36
2023-09-19 08:19:25 -07:00
Andrey Goncharov
9d4ce0586d Support setting initial power search expression
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410966

fbshipit-source-id: 2dcdb4495275dfdca7920af26bbfea4fb95ac419
2023-09-19 08:19:25 -07:00
Andrey Goncharov
ba812eaea6 Fix empty filter bug
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410974

fbshipit-source-id: 4845f32e6be6375e113053b7123df6e78b44b269
2023-09-19 08:19:25 -07:00
Andrey Goncharov
e5b2f693a3 Setup power search
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410972

fbshipit-source-id: 35cea0f033c16748e0ceb0921dee8276787fb1a6
2023-09-19 08:19:25 -07:00
Andrey Goncharov
3022b8ddb1 Simplify data table power search config for each column
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49410973

fbshipit-source-id: d8854eefaf1901c4984300df955a15c77c03505e
2023-09-19 08:19:25 -07:00
Andrey Goncharov
3b75b6994b Allow disabling power search for certain columns
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49373658

fbshipit-source-id: 872bd6ecdce9c3ed7934f86f1954efdff76185b9
2023-09-19 08:19:25 -07:00
Andrey Goncharov
c75c377818 Expose DataTable and DataTableManager
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49349842

fbshipit-source-id: 927dc817e09d830feab9ba3e5e566ddb17fe1ad0
2023-09-19 08:19:25 -07:00
Andrey Goncharov
a86c8b412f Remove search history from context menu
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49410968

fbshipit-source-id: a5160bb5d392f3884d46a3a390aa9e274d0230ea
2023-09-19 08:19:25 -07:00
Andrey Goncharov
d09dde724b Add search icon
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49349828

fbshipit-source-id: 45a9917366236dda6c2409c30a4800cfe53dbd56
2023-09-19 08:19:25 -07:00
Andrey Goncharov
54a93c03aa Compute power search config from columns
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49349521

fbshipit-source-id: 49f8059bdbfbcc316b79eb633ec54d957f16548d
2023-09-19 08:19:25 -07:00
Andrey Goncharov
8cea5be59d Add min width for term finder
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49349523

fbshipit-source-id: a9b9a14a74f9c32e094936e4bd38bef8f34e4c2c
2023-09-19 08:19:25 -07:00
Andrey Goncharov
f86dba951b Fix Searchbar styles
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49349522

fbshipit-source-id: fa37cd0dcca291788834e76df3d4475842df8d48
2023-09-19 08:19:25 -07:00
Andrey Goncharov
54085eb79f Add context menu
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49276995

fbshipit-source-id: 83c1346c6c5869c2608b73b11d40f7f55a7a694b
2023-09-19 08:19:25 -07:00
Andrey Goncharov
bad3dfa20a Hide filter buttons
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49276686

fbshipit-source-id: 5bfea4b7ef87b8d71aa4cb5a1dc3f9a94ea420f0
2023-09-19 08:19:25 -07:00
Andrey Goncharov
9dbd6f7732 Allow TableHead hide filter button
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49276687

fbshipit-source-id: dfa2a51e3bfa84ad3e39b6a4b3a4e279cf63c1d5
2023-09-19 08:19:25 -07:00
Andrey Goncharov
de5f9bc32a Add bolirplate for power search integration
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49272248

fbshipit-source-id: ad6d88568f40bd698faed4c3fc0fc55efd93f5f3
2023-09-19 08:19:25 -07:00
Andrey Goncharov
0cdc7d41be Add MasterDetailWithPowerSearch
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: LukeDefeo

Differential Revision: D49271463

fbshipit-source-id: 1309227024dd02e0f683a3c427b61663fb7a212f
2023-09-19 08:19:25 -07:00
Andrey Goncharov
1cf7160b2c Add same_as_absolute_date_no_time operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: lblasa, antonk52

Differential Revision: D49232775

fbshipit-source-id: 0ad6fafdd998f79a8b96bf9cd9d6e012e6e3a492
2023-09-14 04:48:12 -07:00
Andrey Goncharov
7d90493148 Add older_than_absolute_date_no_time operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49232776

fbshipit-source-id: 1083c277c78cd6eb2bae069966a9de290aa71930
2023-09-14 04:48:12 -07:00
Andrey Goncharov
ea1d2e9813 Add older_than_absolute_date operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: lblasa, antonk52

Differential Revision: D49232777

fbshipit-source-id: ec82faca4690d099c6c9d0427c569bfe2a9dd233
2023-09-14 04:48:12 -07:00
Andrey Goncharov
7a6d895aa8 Add newer_than_absolute_date_no_time operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: lblasa

Differential Revision: D49232773

fbshipit-source-id: 96ab2d0d5cc804c1fcf1e64475fd68de60fa797a
2023-09-14 04:48:12 -07:00
Andrey Goncharov
ad6b3ed4f9 Add newer_than_absolute_date operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: lblasa, antonk52

Differential Revision: D49232772

fbshipit-source-id: 578378faffd83da10df103715734603c67bebb83
2023-09-14 04:48:12 -07:00
Andrey Goncharov
51073bc665 Add float_equals operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230150

fbshipit-source-id: 976055a555d02ea61e29b4f2e939c9c89e44fd49
2023-09-14 04:48:12 -07:00
Andrey Goncharov
a0f02c57e4 Add int_equals operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230145

fbshipit-source-id: 3fa4332ca3129a2a652cf2c33a4383f100d50e33
2023-09-14 04:48:12 -07:00
Andrey Goncharov
3a4dada2fc Add is_nullish operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230135

fbshipit-source-id: 1f7d88512eb3ed592eb406f0950ffa0c6985772c
2023-09-14 04:48:12 -07:00
Andrey Goncharov
75884674e0 Add enum_is_not operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230146

fbshipit-source-id: 66ab340b52a1de1935b4d2f1ef4bc81dc16310f0
2023-09-14 04:48:12 -07:00
Andrey Goncharov
6857e1fb26 Add enum_set_is_none_of operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230148

fbshipit-source-id: b0aa4e702b27359e513b2557c80b6bab529618d5
2023-09-14 04:48:12 -07:00
Andrey Goncharov
12179a35da Add enum_set_is_any_of operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: antonk52

Differential Revision: D49230147

fbshipit-source-id: a020d182a36affe65ed9ab3eb6a1197ddd12270b
2023-09-14 04:48:12 -07:00
Andrey Goncharov
61160a2d4b Add enum_is operator
Summary: Doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU/edit#heading=h.pg8svtdjlx7

Reviewed By: lblasa, antonk52

Differential Revision: D49230138

fbshipit-source-id: f20a1a053cc6370acec57e63df80691c64bffc90
2023-09-14 04:48:12 -07:00