Summary:
Just shows some warnings when running `yarn lint` otherwise about lack of compatibility.
Required updating the rules because of a breaking change here: https://github.com/typescript-eslint/typescript-eslint/pull/3800/files
Reviewed By: lblasa
Differential Revision: D33533052
fbshipit-source-id: fd73d534bbd6e1933321b5811832b05a9739af95
Summary:
`console.error(err)` are hard to identify in the codebase especially
as we often don't have reliable stack trace information.
I've already cleaned up a bunch of them manually by going after the most
high-firing ones; this should make it easier to identify the remaining ones.
Reviewed By: jknoxville
Differential Revision: D27913964
fbshipit-source-id: 0ff6624a0c083829846550b40954945d655b7cf6
Summary:
I don't think there's an easy way to do this based on types
which would be ideal ...
So instead I'm checking for
- Importing `remote` from `electron`.
- Accessing `electron.remote`.
You can still hack this by importing `electron`, saving
it to a differently named variable and accessing `remote` on it,
but this should cover all reasonable cases we see in real code.
Reviewed By: mweststrate
Differential Revision: D26453006
fbshipit-source-id: 4b3d223bed43ca3f0d1a4f592ea8f8060a823479
Summary:
Added infra for writing and using custom eslint rules and created a rule for disallowing cross-package file imports. Such imports are anti-pattern and they also break standalone plugin bundling.
We still have a bunch of places where Flipper core references code directly from plugins. I've ignored these places for now and added task T71355623 to revisit them.
Reviewed By: passy
Differential Revision: D22998955
fbshipit-source-id: d04cff8fc115ba1300a7e6830306ec134046e927
