From ffe53d13451703c4e0b296dbc0f566b93e3a030a Mon Sep 17 00:00:00 2001 From: Sara Valderrama Date: Thu, 26 Jul 2018 15:18:30 -0700 Subject: [PATCH] Small sidebar update Summary: Added some props to sidebar for ax mode. Differential Revision: D8983386 fbshipit-source-id: eaf414dc8ae5386744c66f1d43b6b9068b9593c1 --- .../inspector/descriptors/ViewDescriptor.java | 12 ++++++------ .../descriptors/utils/AccessibilityUtil.java | 8 ++++++++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/ViewDescriptor.java b/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/ViewDescriptor.java index ce5f167f5..49a918890 100644 --- a/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/ViewDescriptor.java +++ b/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/ViewDescriptor.java @@ -408,14 +408,14 @@ public class ViewDescriptor extends NodeDescriptor { case "content-description": node.setContentDescription(value.asString()); break; - case "label-for": - node.setLabelFor(value.asInt()); + case "long-clickable": + node.setLongClickable(value.asBoolean()); break; - case "traversal-after": - node.setAccessibilityTraversalAfter(value.asInt()); + case "clickable": + node.setClickable(value.asBoolean()); break; - case "traversal-before": - node.setAccessibilityTraversalBefore(value.asInt()); + case "selected": + node.setSelected(value.asBoolean()); break; } invalidate(node); diff --git a/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/utils/AccessibilityUtil.java b/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/utils/AccessibilityUtil.java index 7df974331..d6d08d002 100644 --- a/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/utils/AccessibilityUtil.java +++ b/android/src/main/java/com/facebook/sonar/plugins/inspector/descriptors/utils/AccessibilityUtil.java @@ -448,6 +448,14 @@ public final class AccessibilityUtil { view.getContentDescription() != null ? view.getContentDescription() : ""; props.put("content-description", InspectorValue.mutable(contentDescription)); props.put("focusable", InspectorValue.mutable(view.isFocusable())); + props.put("selected", InspectorValue.mutable(view.isSelected())); + props.put("long-clickable", InspectorValue.mutable(view.isLongClickable())); + props.put("clickable", InspectorValue.mutable(view.isClickable())); + props.put("focused", view.isFocused()); + + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + props.put("accessibility-focused", view.isAccessibilityFocused()); + } if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) { props.put(