From ff85744911d1fbaa142214cd830b12891019a0ef Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Thu, 6 Apr 2023 10:10:34 -0700
Subject: [PATCH] Make DataView report window changes

Summary: Project: https://docs.google.com/document/d/1x-1ShlxXCM2od9JMO6PP14Cuqq0OrVe1Qd7FUwTos9A/edit

Reviewed By: antonk52

Differential Revision: D44748055

fbshipit-source-id: 409c272b12fb29c156efdaa1ab26d4d6a2936645
---
 .../flipper-plugin-core/src/data-source/DataSource.tsx | 10 ++++++++++
 .../data-source/__tests__/datasource-basics.node.tsx   |  9 +++++++++
 desktop/flipper-plugin/src/__tests__/api.node.tsx      |  1 +
 3 files changed, 20 insertions(+)

diff --git a/desktop/flipper-plugin-core/src/data-source/DataSource.tsx b/desktop/flipper-plugin-core/src/data-source/DataSource.tsx
index 9880f4f23..9cc56bf8c 100644
--- a/desktop/flipper-plugin-core/src/data-source/DataSource.tsx
+++ b/desktop/flipper-plugin-core/src/data-source/DataSource.tsx
@@ -83,6 +83,11 @@ type OutputChange =
       // like: clear, filter or sorting change, etc
       type: 'reset';
       newCount: number;
+    }
+  | {
+      type: 'windowChange';
+      newStart: number;
+      newEnd: number;
     };
 
 export type DataSourceOptionKey<K extends PropertyKey> = {
@@ -582,6 +587,11 @@ export class DataSourceView<T, KeyType> {
   public setWindow(start: number, end: number) {
     this.windowStart = start;
     this.windowEnd = end;
+    this.notifyAllListeners({
+      type: 'windowChange',
+      newStart: start,
+      newEnd: end,
+    });
   }
 
   public addListener(listener: (change: OutputChange) => void) {
diff --git a/desktop/flipper-plugin-core/src/data-source/__tests__/datasource-basics.node.tsx b/desktop/flipper-plugin-core/src/data-source/__tests__/datasource-basics.node.tsx
index bc4e0df51..cb78e07c6 100644
--- a/desktop/flipper-plugin-core/src/data-source/__tests__/datasource-basics.node.tsx
+++ b/desktop/flipper-plugin-core/src/data-source/__tests__/datasource-basics.node.tsx
@@ -520,6 +520,7 @@ test('it emits the right events - small window', () => {
       ds.update(1, 'x');
     }),
   ).toEqual([
+    {newEnd: 3, newStart: 0, type: 'windowChange'},
     {delta: 1, location: 'in', newCount: 3, type: 'shift', index: 2},
     {index: 1, type: 'update'},
   ]);
@@ -541,6 +542,7 @@ test('it emits the right events - view change', () => {
       // b, [c], x, y
     }),
   ).toEqual([
+    {newEnd: 2, newStart: 1, type: 'windowChange'},
     {newCount: 2, type: 'reset'},
     {index: 0, delta: -1, location: 'before', newCount: 1, type: 'shift'}, // remove a
     {index: 1, delta: 1, location: 'in', newCount: 2, type: 'shift'}, // pre-insert x
@@ -568,6 +570,7 @@ test('it emits the right events - reversed view change', () => {
       // y, [x], c, b, a
     }),
   ).toEqual([
+    {newEnd: 2, newStart: 1, type: 'windowChange'},
     {newCount: 2, type: 'reset'},
     {newCount: 2, type: 'reset'}, // FIXME: ideally dedupe these, but due to scheduling will do little harm
     {index: 1, delta: -1, location: 'in', newCount: 1, type: 'shift'}, // remove a
@@ -604,6 +607,7 @@ test('it emits the right events - reversed view change with filter', () => {
       // [b, a]
     }),
   ).toEqual([
+    {newEnd: 2, newStart: 0, type: 'windowChange'},
     {newCount: 2, type: 'reset'},
     {newCount: 2, type: 'reset'}, // FIXME: ideally dedupe these, but due to scheduling will do little harm
     {newCount: 2, type: 'reset'}, // FIXME: ideally dedupe these, but due to scheduling will do little harm
@@ -634,6 +638,7 @@ test('basic remove', () => {
       'id',
     ),
   ).toEqual([
+    {newEnd: 100, newStart: 0, type: 'windowChange'},
     {
       type: 'shift',
       newCount: 2,
@@ -675,6 +680,7 @@ test('basic shift', () => {
       'id',
     ),
   ).toEqual([
+    {newEnd: 100, newStart: 0, type: 'windowChange'},
     {
       type: 'shift',
       newCount: 1,
@@ -700,6 +706,7 @@ test('sorted shift', () => {
       ds.shift(1); // optimizes to reset
     }),
   ).toEqual([
+    {newEnd: 100, newStart: 0, type: 'windowChange'},
     {newCount: 5, type: 'reset'}, // sort
     {delta: -1, index: 4, location: 'in', newCount: 4, type: 'shift'}, // e
     {delta: -1, index: 0, location: 'in', newCount: 3, type: 'shift'}, // a
@@ -719,6 +726,7 @@ test('filtered shift', () => {
       expect(ds.view.output()).toEqual(['d']);
     }),
   ).toEqual([
+    {newEnd: 100, newStart: 0, type: 'windowChange'},
     {newCount: 3, type: 'reset'}, // filter
     {type: 'shift', location: 'in', newCount: 1, index: 0, delta: -2}, // optimized shift
   ]);
@@ -746,6 +754,7 @@ test('remove after shift works correctly', () => {
       'id',
     ),
   ).toEqual([
+    {newEnd: 100, newStart: 0, type: 'windowChange'},
     {
       type: 'shift',
       newCount: 3,
diff --git a/desktop/flipper-plugin/src/__tests__/api.node.tsx b/desktop/flipper-plugin/src/__tests__/api.node.tsx
index 1a9135676..5b2e1d033 100644
--- a/desktop/flipper-plugin/src/__tests__/api.node.tsx
+++ b/desktop/flipper-plugin/src/__tests__/api.node.tsx
@@ -92,6 +92,7 @@ test('Correct top level API exposed', () => {
       "CreatePasteResult",
       "DataDescriptionType",
       "DataInspectorExpanded",
+      "DataSourceVirtualizer",
       "DataTableColumn",
       "DataTableManager",
       "DataValueExtractor",