jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix strict errors

Browse Source 
Summary: fixing some errors for strict mode enabled files

Reviewed By: passy

Differential Revision: D16988271

fbshipit-source-id: 09834cad9c2dd8abb987e4f708ae7a30922d90c7
This commit is contained in:
Daniel Büchele
2019-08-28 11:10:20 -07:00
committed by Facebook Github Bot
parent 8d653672f2
commit ff31ac0b45
3 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/ui/components/Sidebar.tsx
View File

@@ -134,12 +134,12 @@ export default class Sidebar extends Component<SidebarProps, SidebarState> {
render() {
const {backgroundColor, onResize, position, children} = this.props;
let height: number;
let minHeight: number;
let maxHeight: number;
let width: number;
let minWidth: number;
let maxWidth: number;
let height: number | undefined;
let minHeight: number | undefined;
let maxHeight: number | undefined;
let width: number | undefined;
let minWidth: number | undefined;
let maxWidth: number | undefined;
const resizable: {[key: string]: boolean} = {};
if (position === 'left') {

23
src/ui/components/searchable/Searchable.tsx
View File

@@ -143,7 +143,13 @@ const Searchable = (
componentDidMount() {
window.document.addEventListener('keydown', this.onKeyDown);
const {defaultFilters} = this.props;
let savedState;
let savedState:
| {
filters: Array<Filter>;
regexEnabled?: boolean;
searchTerm?: string;
}
| undefined;
if (this.getTableKey()) {
try {
@@ -163,16 +169,19 @@ const Searchable = (
const filterIndex = savedStateFilters.findIndex(
f => f.key === defaultFilter.key,
);
if (filterIndex > -1) {
const savedDefaultFilter = savedStateFilters[filterIndex];
if (filterIndex > -1 && savedDefaultFilter.type === 'enum') {
if (defaultFilter.type === 'enum') {
savedStateFilters[filterIndex].enum = defaultFilter.enum;
savedDefaultFilter.enum = defaultFilter.enum;
}
const filters = new Set(
savedStateFilters[filterIndex].enum.map(filter => filter.value),
savedDefaultFilter.enum.map(filter => filter.value),
);
savedStateFilters[filterIndex].value = savedStateFilters[
savedStateFilters[
filterIndex
].value.filter(value => filters.has(value));
].value = savedDefaultFilter.value.filter(value =>
filters.has(value),
);
}
});
}
@@ -242,7 +251,7 @@ const Searchable = (
};
onKeyDown = (e: KeyboardEvent) => {
const ctrlOrCmd = e =>
const ctrlOrCmd = (e: KeyboardEvent) =>
(e.metaKey && process.platform === 'darwin') ||
(e.ctrlKey && process.platform !== 'darwin');