jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Catch receiver errors

Browse Source 
Summary:
This change adds a safety net for receivers that may throw an exception on invocation.

Without this change, the exception is logged but not shown in Flipper.

Reviewed By: nikoant

Differential Revision: D34001224

fbshipit-source-id: ca07d3dd006b277e306ecbc1c033845929a83f4c
This commit is contained in:
Lorenzo Blasa
2022-02-04 07:04:12 -08:00
committed by Facebook GitHub Bot
parent 4f9cec718e
commit fd3d4d4efb
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
xplat/Flipper/FlipperConnectionImpl.h
View File

@@ -33,7 +33,15 @@ class FlipperConnectionImpl : public FlipperConnection {
responder->error(folly::dynamic::object("message", errorMessage)); responder->error(folly::dynamic::object("message", errorMessage));
return; return;
} }
receivers_.at(method)(params, responder); try {
receivers_.at(method)(params, responder);
} catch (const std::exception& ex) {
std::string errorMessage = "Receiver " + method + " failed with error. ";
std::string reason = ex.what();
errorMessage += "Error: '" + reason + "'.";
log("Error: " + errorMessage);
responder->error(folly::dynamic::object("message", errorMessage));
}
} }
void send(const std::string& method, const folly::dynamic& params) override { void send(const std::string& method, const folly::dynamic& params) override {