jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use BaseDevice from flipper-frontend-core in flipper-ui-core

Browse Source 
Summary: Use BasDevice definition from flipper-frontend-core in flipper-ui-core and remove the redundant definition from flipper-ui-core

Reviewed By: lblasa

Differential Revision: D37234785

fbshipit-source-id: 6e768090a197c1d2c49cb1cd573acea12fb65d24
This commit is contained in:
Andrey Goncharov
2022-06-20 12:18:40 -07:00
committed by Facebook GitHub Bot
parent ef5fa275a3
commit fd380a4c1e
32 changed files with 29 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppInspect.tsx
View File

@@ -18,7 +18,7 @@ import ScreenCaptureButtons from '../../chrome/ScreenCaptureButtons';
import MetroButton from '../../chrome/MetroButton';
import {BookmarkSection} from './BookmarkSection';
import Client from '../../Client';
import BaseDevice from '../../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {ExclamationCircleOutlined, FieldTimeOutlined} from '@ant-design/icons';
import {useSelector} from 'react-redux';
import {

2
desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppSelector.tsx
View File

@@ -25,7 +25,7 @@ import {
selectClient,
selectDevice,
} from '../../reducers/connections';
import BaseDevice from '../../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import Client from '../../Client';
import {State} from '../../reducers';
import {brandColors, brandIcons, colors} from '../../ui/components/colors';

2
desktop/flipper-ui-core/src/sandy-chrome/appinspect/PluginList.tsx
View File

@@ -23,7 +23,7 @@ import {useDispatch, useStore} from '../../utils/useStore';
import {getPluginTitle, getPluginTooltip} from '../../utils/pluginUtils';
import {selectPlugin} from '../../reducers/connections';
import Client from '../../Client';
import BaseDevice from '../../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {DownloadablePluginDetails} from 'flipper-common';
import {
DownloadablePluginState,

2
desktop/flipper-ui-core/src/sandy-chrome/appinspect/__tests__/PluginList.spec.tsx
View File

@@ -12,7 +12,7 @@ import {
MockFlipperResult,
} from '../../../__tests__/test-utils/createMockFlipperWithPlugin';
import {FlipperPlugin} from '../../../plugin';
import BaseDevice from '../../../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {_SandyPluginDefinition} from 'flipper-plugin';
import {TestUtils} from 'flipper-plugin';
import {selectPlugin} from '../../../reducers/connections';

2
desktop/flipper-ui-core/src/sandy-chrome/notification/Notification.tsx
View File

@@ -311,8 +311,6 @@ export function openNotification(store: Store, noti: PluginNotificationOrig) {
selectPlugin({
selectedPlugin: noti.pluginId,
selectedAppId: client.id,
// TODO: Will be fixed later in the stack
// @ts-expect-error
selectedDevice: client.device,
deepLinkPayload: noti.notification.action,
}),