jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use BaseDevice from flipper-frontend-core in flipper-ui-core

Browse Source 
Summary: Use BasDevice definition from flipper-frontend-core in flipper-ui-core and remove the redundant definition from flipper-ui-core

Reviewed By: lblasa

Differential Revision: D37234785

fbshipit-source-id: 6e768090a197c1d2c49cb1cd573acea12fb65d24
This commit is contained in:
Andrey Goncharov
2022-06-20 12:18:40 -07:00
committed by Facebook GitHub Bot
parent ef5fa275a3
commit fd380a4c1e
32 changed files with 29 additions and 462 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-ui-core/src/dispatcher/__tests__/pluginManager.node.tsx
View File

@@ -21,7 +21,7 @@ import {_SandyPluginDefinition as SandyPluginDefinition} from 'flipper-plugin';
import MockFlipper from '../../__tests__/test-utils/MockFlipper';
import Client from '../../Client';
import React from 'react';
import BaseDevice from '../../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {awaitPluginCommandQueueEmpty} from '../pluginManager';
const pluginDetails1 = TestUtils.createMockPluginDetails({

4
desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
View File

@@ -19,7 +19,7 @@ import {
} from 'flipper-common';
import Client from '../Client';
import {notification} from 'antd';
import BaseDevice from '../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {ClientDescription, timeout} from 'flipper-common';
import {reportPlatformFailures} from 'flipper-common';
import {sideEffect} from '../utils/sideEffect';
@@ -300,8 +300,6 @@ export async function handleClientConnected(
logger,
store,
undefined,
// TODO: Remove at the end of migration
// @ts-expect-error
device,
server,
);

6
desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx
View File

@@ -27,7 +27,7 @@ import {loadPluginsFromMarketplace} from './pluginMarketplace';
import {loadPlugin, switchPlugin} from '../reducers/pluginManager';
import {startPluginDownload} from '../reducers/pluginDownloads';
import isProduction from '../utils/isProduction';
import BaseDevice from '../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import Client from '../Client';
import {RocketOutlined} from '@ant-design/icons';
import {showEmulatorLauncher} from '../sandy-chrome/appinspect/LaunchEmulator';
@@ -122,8 +122,6 @@ export async function handleOpenPluginDeeplink(
const client: Client | undefined = isDevicePlugin
? undefined
: (deviceOrClient as Client);
// TODO: Remove at the end of migration
// @ts-expect-error
const device: BaseDevice = isDevicePlugin
? (deviceOrClient as BaseDevice)
: (deviceOrClient as Client).device;
@@ -509,8 +507,6 @@ async function selectDevicesAndClient(
: c.plugins.has(params.pluginId),
)
.filter((c) => c.connected.get())
// TODO: Remove at the end of migration
// @ts-expect-error
.filter((c) => availableDevices.includes(c.device));
if (validClients.length === 1) {

2
desktop/flipper-ui-core/src/dispatcher/tracking.tsx
View File

@@ -22,7 +22,7 @@ import {
selectionChanged,
} from '../reducers/usageTracking';
import produce from 'immer';
import BaseDevice from '../devices/BaseDevice';
import {BaseDevice} from 'flipper-frontend-core';
import {deconstructClientId} from 'flipper-common';
import {sideEffect} from '../utils/sideEffect';
import {getSelectionInfo} from '../utils/info';