Clean up dependencies (#153)

Summary:
Remove unused dependencies and centralise the remaining ones in the
global project config.
Pull Request resolved: https://github.com/facebook/Sonar/pull/153

Reviewed By: priteshrnandgaonkar

Differential Revision: D8820462

Pulled By: passy

fbshipit-source-id: 1c845898930eb62942379fddec6da39dbdc426d0
This commit is contained in:
Pascal Hartig
2018-07-12 08:48:11 -07:00
committed by Facebook Github Bot
parent c871496f8c
commit fcd1b1e773
4 changed files with 15 additions and 29 deletions

View File

@@ -247,10 +247,7 @@ android {
dependencies { dependencies {
compileOnly deps.lithoAnnotations compileOnly deps.lithoAnnotations
compileOnly 'org.glassfish:javax.annotation:10.0-b28'
implementation project(':fbjni') implementation project(':fbjni')
implementation deps.soloader implementation deps.soloader
implementation deps.guava implementation deps.guava
implementation deps.jsr305 implementation deps.jsr305

View File

@@ -28,29 +28,18 @@ android {
dependencies { dependencies {
// Android Support Library
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation deps.supportAppCompat implementation deps.supportAppCompat
implementation deps.supportConstraintLayout
implementation deps.supportDesign
testImplementation deps.junit
androidTestImplementation deps.supportTestRunner
androidTestImplementation deps.supportEspresso
// Litho // Litho
implementation deps.lithoCore implementation deps.lithoCore
implementation deps.lithoWidget implementation deps.lithoWidget
compileOnly deps.lithoAnnotations compileOnly deps.lithoAnnotations
annotationProcessor deps.lithoProcessor annotationProcessor deps.lithoProcessor
// SoLoader // Third-party
implementation deps.soloader implementation deps.soloader
// For integration with Fresco
implementation deps.lithoFresco
// For testing
testImplementation deps.lithoTesting
implementation deps.okhttp3 implementation deps.okhttp3
implementation project(':android') implementation project(':android')
} }

View File

@@ -2,24 +2,22 @@
package com.facebook.sonar.sample; package com.facebook.sonar.sample;
import android.util.Log;
import com.facebook.litho.ClickEvent;
import com.facebook.litho.Column; import com.facebook.litho.Column;
import com.facebook.litho.Component; import com.facebook.litho.Component;
import com.facebook.litho.ComponentContext; import com.facebook.litho.ComponentContext;
import com.facebook.litho.annotations.LayoutSpec; import com.facebook.litho.annotations.LayoutSpec;
import com.facebook.litho.annotations.OnCreateLayout; import com.facebook.litho.annotations.OnCreateLayout;
import com.facebook.litho.annotations.OnEvent;
import com.facebook.litho.widget.Text; import com.facebook.litho.widget.Text;
import okhttp3.Request; import java.io.IOException;
import okhttp3.Response;
import okhttp3.RequestBody;
import okhttp3.FormBody;
import okhttp3.FormBody.Builder;
import okhttp3.OkHttpClient;
import okhttp3.Call; import okhttp3.Call;
import okhttp3.Callback; import okhttp3.Callback;
import com.facebook.litho.ClickEvent; import okhttp3.FormBody;
import android.util.Log; import okhttp3.Request;
import java.io.IOException; import okhttp3.RequestBody;
import com.facebook.litho.annotations.OnEvent; import okhttp3.Response;
@LayoutSpec @LayoutSpec
public class RootComponentSpec { public class RootComponentSpec {

View File

@@ -62,5 +62,7 @@ ext.deps = [
robolectric : 'org.robolectric:robolectric:3.0', robolectric : 'org.robolectric:robolectric:3.0',
junit : 'junit:junit:4.12', junit : 'junit:junit:4.12',
stetho : 'com.facebook.stetho:stetho:1.5.0', stetho : 'com.facebook.stetho:stetho:1.5.0',
okhttp3 : 'com.squareup.okhttp3:okhttp:3.10.0' okhttp3 : 'com.squareup.okhttp3:okhttp:3.10.0',
// Plugin dependencies
rhino : 'org.mozilla:rhino:1.7.10',
] ]