prettier 2
Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d9d3be33b4
commit
fc9ed65762
@@ -29,7 +29,7 @@ function preludeBundle(
|
||||
) {
|
||||
const revisionStr =
|
||||
buildRevision == null ? '' : `global.__REVISION__="${buildRevision}";`;
|
||||
return new Promise(resolve =>
|
||||
return new Promise((resolve) =>
|
||||
lineReplace({
|
||||
file: path.join(dir, 'bundle.js'),
|
||||
line: 1,
|
||||
@@ -41,18 +41,18 @@ function preludeBundle(
|
||||
}
|
||||
|
||||
async function createZip(buildDir: string, distDir: string, targets: string[]) {
|
||||
return new Promise(resolve => {
|
||||
return new Promise((resolve) => {
|
||||
const zip = new yazl.ZipFile();
|
||||
|
||||
// add binaries for each target
|
||||
targets.forEach(target => {
|
||||
targets.forEach((target) => {
|
||||
const binary = `flipper-${target === 'mac' ? 'macos' : target}`;
|
||||
zip.addFile(path.join(buildDir, binary), binary);
|
||||
});
|
||||
|
||||
// add plugins
|
||||
const pluginDir = path.join(buildDir, PLUGINS_FOLDER_NAME);
|
||||
fs.readdirSync(pluginDir).forEach(file => {
|
||||
fs.readdirSync(pluginDir).forEach((file) => {
|
||||
zip.addFile(
|
||||
path.join(pluginDir, file),
|
||||
path.join(PLUGINS_FOLDER_NAME, file),
|
||||
|
||||
Reference in New Issue
Block a user