prettier 2
Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d9d3be33b4
commit
fc9ed65762
@@ -18,7 +18,7 @@ const stringCombination = (patterns: Array<string>, k: number) => {
|
||||
const returnArr: Array<string> = new Array(0);
|
||||
const args = new Array(k).fill(0).map((_, idx) => idx);
|
||||
(function build(args) {
|
||||
const pattern = args.map(i => patterns[i]).join('');
|
||||
const pattern = args.map((i) => patterns[i]).join('');
|
||||
returnArr.push(pattern);
|
||||
if (args[args.length - 1] < n - 1) {
|
||||
for (let i = args.length - 1; i >= 0; i--) {
|
||||
@@ -55,7 +55,7 @@ const constructMatchPatterns: () => Map<string, URI> = () => {
|
||||
'yzyzyzyzyzyzyzyzyzyzyzyzy',
|
||||
];
|
||||
|
||||
stringCombination(patterns, NUM_PATERNS_PER_ENTRY).forEach(pattern =>
|
||||
stringCombination(patterns, NUM_PATERNS_PER_ENTRY).forEach((pattern) =>
|
||||
matchPatterns.set(pattern, pattern),
|
||||
);
|
||||
|
||||
|
||||
@@ -49,7 +49,7 @@ const IconButton = styled.div({
|
||||
},
|
||||
});
|
||||
|
||||
export default function(props: Props) {
|
||||
export default function (props: Props) {
|
||||
return (
|
||||
<RippleEffect>
|
||||
<IconButton className="icon-button" onClick={props.onClick}>
|
||||
|
||||
@@ -76,7 +76,7 @@ export default (props: Props) => {
|
||||
}
|
||||
className={event.className}
|
||||
uri={event.uri}
|
||||
onNavigate={uri => {
|
||||
onNavigate={(uri) => {
|
||||
if (timelineRef.current != null) {
|
||||
timelineRef.current.scrollTo(0, 0);
|
||||
}
|
||||
|
||||
@@ -106,7 +106,7 @@ export default class extends FlipperPlugin<State, any, PersistedState> {
|
||||
const {selectedApp} = this.props;
|
||||
this.subscribeToNavigationEvents();
|
||||
this.getDevice()
|
||||
.then(device => getAppMatchPatterns(selectedApp, device))
|
||||
.then((device) => getAppMatchPatterns(selectedApp, device))
|
||||
.then((patterns: Array<AppMatchPattern>) => {
|
||||
this.props.setPersistedState({
|
||||
appMatchPatterns: patterns,
|
||||
@@ -118,7 +118,7 @@ export default class extends FlipperPlugin<State, any, PersistedState> {
|
||||
.catch(() => {
|
||||
/* Silently fail here. */
|
||||
});
|
||||
readBookmarksFromDB().then(bookmarks => {
|
||||
readBookmarksFromDB().then((bookmarks) => {
|
||||
this.props.setPersistedState({
|
||||
bookmarks: bookmarks,
|
||||
bookmarksProvider: bookmarksToAutoCompleteProvider(bookmarks),
|
||||
|
||||
@@ -43,7 +43,7 @@ export const appMatchPatternsToAutoCompleteProvider = (
|
||||
icon: 'mobile',
|
||||
matchPatterns: new Map<string, URI>(),
|
||||
};
|
||||
appMatchPatterns.forEach(appMatchPattern => {
|
||||
appMatchPatterns.forEach((appMatchPattern) => {
|
||||
const matchPattern =
|
||||
appMatchPattern.className + ' - ' + appMatchPattern.pattern;
|
||||
autoCompleteProvider.matchPatterns.set(
|
||||
|
||||
@@ -88,7 +88,7 @@ export const readBookmarksFromDB: () => Promise<Map<string, Bookmark>> = () => {
|
||||
});
|
||||
};
|
||||
|
||||
export const removeBookmark: (uri: string) => Promise<void> = uri => {
|
||||
export const removeBookmark: (uri: string) => Promise<void> = (uri) => {
|
||||
return new Promise<void>((resolve, reject) => {
|
||||
openNavigationPluginDB()
|
||||
.then((db: IDBDatabase) => {
|
||||
|
||||
@@ -25,10 +25,7 @@ export const filterOptionalParameters = (uri: string) => {
|
||||
|
||||
export const parseURIParameters = (query: string) => {
|
||||
// get parameters from query string and store in Map
|
||||
const parameters = query
|
||||
.split('?')
|
||||
.splice(1)
|
||||
.join('');
|
||||
const parameters = query.split('?').splice(1).join('');
|
||||
const parametersObj = querystring.parse(parameters);
|
||||
const parametersMap = new Map<string, string>();
|
||||
for (const key in parametersObj) {
|
||||
|
||||
Reference in New Issue
Block a user