prettier 2

Summary:
Quick notes:

- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.

Close https://github.com/facebook/flipper/pull/915

Reviewed By: jknoxville

Differential Revision: D20594929

fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03

desktop/plugins/layout/Inspector.tsx

@@ -78,7 +78,7 @@ export default class Inspector extends Component<Props> {
     const elements: Array<Element> = Object.values(
       this.props.persistedState.AXelements,
     );
-    const focusedElement = elements.find(i =>
+    const focusedElement = elements.find((i) =>
       Boolean(
         i.data.Accessibility && i.data.Accessibility['accessibility-focused'],
       ),
@@ -115,7 +115,7 @@ export default class Inspector extends Component<Props> {
         nodes: Array<{id: ElementID; children: Array<ElementID>}>;
       }) => {
         const ids = nodes
-          .map(n => [n.id, ...(n.children || [])])
+          .map((n) => [n.id, ...(n.children || [])])
           .reduce((acc, cv) => acc.concat(cv), []);
         this.invalidate(ids);
       },
@@ -279,7 +279,7 @@ export default class Inspector extends Component<Props> {
           selected: false,
         },
       );
-      elements.forEach(e => this.updateElement(e.id, e));
+      elements.forEach((e) => this.updateElement(e.id, e));
       return elements;
     } else {
       return [];
@@ -287,7 +287,7 @@ export default class Inspector extends Component<Props> {
   }
 
   async getAndExpandPath(path: Array<ElementID>) {
-    await Promise.all(path.map(id => this.getChildren(id, {})));
+    await Promise.all(path.map((id) => this.getChildren(id, {})));
     this.onElementSelected(path[path.length - 1]);
   }
 
@@ -312,9 +312,9 @@ export default class Inspector extends Component<Props> {
     if (shouldExpand) {
       this.updateElement(id, {expanded: shouldExpand});
     }
-    this.getChildren(id, {}).then(children => {
+    this.getChildren(id, {}).then((children) => {
       if (deep) {
-        children.forEach(child =>
+        children.forEach((child) =>
           this.onElementExpanded(child.id, deep, shouldExpand),
         );
       }

desktop/plugins/layout/InspectorSidebar.tsx

@@ -148,12 +148,12 @@ const Sidebar: React.FC<Props> = (props: Props) => {
 
   const sections: Array<React.ReactNode> = (
     (SidebarExtensions &&
-      SidebarExtensions.map(ext =>
+      SidebarExtensions.map((ext) =>
         ext(props.client, props.realClient, element.id, props.logger),
       )) ||
     []
   ).concat(
-    sectionDefs.map(def => (
+    sectionDefs.map((def) => (
       <InspectorSidebarSection
         tooltips={props.tooltips}
         key={def.key}
@@ -165,7 +165,7 @@ const Sidebar: React.FC<Props> = (props: Props) => {
   );
 
   useEffect(() => {
-    sectionKeys.map(key =>
+    sectionKeys.map((key) =>
       props.logger.track('usage', `layout-sidebar-extension:${key}:loaded`),
     );
   }, [props.element?.data]);

desktop/plugins/layout/Search.tsx

@@ -99,7 +99,7 @@ export default class Search extends Component<Props, State> {
     } else {
       this.props.client
         .call('getSearchResults', {query, axEnabled: this.props.inAXMode})
-        .then(response =>
+        .then((response) =>
           this.displaySearchResults(response, this.props.inAXMode),
         );
     }
@@ -123,14 +123,14 @@ export default class Search extends Component<Props, State> {
     });
 
     const searchResults = this.getElementsFromSearchResultTree(results);
-    const searchResultIDs = new Set(searchResults.map(r => r.element.id));
+    const searchResultIDs = new Set(searchResults.map((r) => r.element.id));
     const elements: ElementMap = searchResults.reduce(
       (acc: ElementMap, {element}: SearchResultTree) => ({
         ...acc,
         [element.id]: {
           ...element,
           // expand all search results, that we have have children for
-          expanded: element.children.some(c => searchResultIDs.has(c)),
+          expanded: element.children.some((c) => searchResultIDs.has(c)),
         },
       }),
       this.props.persistedState.elements,
@@ -148,7 +148,7 @@ export default class Search extends Component<Props, State> {
             [axElement.id]: {
               ...axElement,
               // expand all search results, that we have have children for
-              expanded: axElement.children.some(c => searchResultIDs.has(c)),
+              expanded: axElement.children.some((c) => searchResultIDs.has(c)),
             },
           };
         },
@@ -160,7 +160,7 @@ export default class Search extends Component<Props, State> {
 
     this.props.onSearchResults({
       matches: new Set(
-        searchResults.filter(x => x.isMatch).map(x => x.element.id),
+        searchResults.filter((x) => x.isMatch).map((x) => x.element.id),
       ),
       query: query,
     });

desktop/plugins/layout/ToolbarIcon.tsx

@@ -24,7 +24,7 @@ const ToolbarIcon = styled.div({
   position: 'relative', // for settings popover positioning
 });
 
-export default function(props: Props) {
+export default function (props: Props) {
   return (
     <ToolbarIcon onClick={props.onClick} title={props.title}>
       <Glyph

desktop/plugins/layout/index.tsx

@@ -177,16 +177,16 @@ export default class Layout extends FlipperPlugin<State, any, PersistedState> {
 
     if (this.props.isArchivedDevice) {
       this.getDevice()
-        .then(d => {
+        .then((d) => {
           const handle = (d as ArchivedDevice).getArchivedScreenshotHandle();
           if (!handle) {
             throw new Error('No screenshot attached.');
           }
           return handle;
         })
-        .then(handle => getFlipperMediaCDN(handle, 'Image'))
-        .then(url => this.setState({visualizerScreenshot: url}))
-        .catch(_ => {
+        .then((handle) => getFlipperMediaCDN(handle, 'Image'))
+        .then((url) => this.setState({visualizerScreenshot: url}))
+        .catch((_) => {
           // Not all exports have screenshots. This is ok.
         });
     }
@@ -332,7 +332,7 @@ export default class Layout extends FlipperPlugin<State, any, PersistedState> {
     const inspector = (
       <Inspector
         {...inspectorProps}
-        onSelect={selectedElement => this.setState({selectedElement})}
+        onSelect={(selectedElement) => this.setState({selectedElement})}
         showsSidebar={!this.state.inAXMode}
       />
     );
@@ -340,7 +340,7 @@ export default class Layout extends FlipperPlugin<State, any, PersistedState> {
     const axInspector = this.state.inAXMode && (
       <Inspector
         {...inspectorProps}
-        onSelect={selectedAXElement => this.setState({selectedAXElement})}
+        onSelect={(selectedAXElement) => this.setState({selectedAXElement})}
         showsSidebar={true}
         ax
       />
@@ -395,7 +395,7 @@ export default class Layout extends FlipperPlugin<State, any, PersistedState> {
                 client={this.getClient()}
                 setPersistedState={this.props.setPersistedState}
                 persistedState={this.props.persistedState}
-                onSearchResults={searchResults =>
+                onSearchResults={(searchResults) =>
                   this.setState({searchResults})
                 }
                 inAXMode={this.state.inAXMode}