prettier 2

Summary:
Quick notes:

- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.

Close https://github.com/facebook/flipper/pull/915

Reviewed By: jknoxville

Differential Revision: D20594929

fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
This commit is contained in:
Pascal Hartig
2020-03-24 09:34:39 -07:00
committed by Facebook GitHub Bot
parent d9d3be33b4
commit fc9ed65762
204 changed files with 877 additions and 864 deletions

View File

@@ -94,7 +94,7 @@ type ImagesCacheOverviewState = {
size: number;
};
const StyledSelect = styled(Select)(props => ({
const StyledSelect = styled(Select)((props) => ({
marginLeft: 6,
marginRight: 6,
height: '100%',
@@ -307,7 +307,7 @@ class ImageGrid extends PureComponent<{
onClear={this.props.onClear}
/>,
<ImageGrid.Content key="content">
{images.map(imageId => (
{images.map((imageId) => (
<ImageItem
imageId={imageId}
image={this.props.imagesMap[imageId]}
@@ -316,7 +316,8 @@ class ImageGrid extends PureComponent<{
onSelected={onImageSelected}
size={this.props.size}
numberOfRequests={
this.props.events.filter(e => e.imageIds.includes(imageId)).length
this.props.events.filter((e) => e.imageIds.includes(imageId))
.length
}
/>
))}
@@ -392,7 +393,7 @@ class ImageItem extends PureComponent<{
size: number;
numberOfRequests: number;
}> {
static Container = styled(FlexBox)<{size: number}>(props => ({
static Container = styled(FlexBox)<{size: number}>((props) => ({
float: 'left',
alignItems: 'center',
justifyContent: 'center',
@@ -416,7 +417,7 @@ class ImageItem extends PureComponent<{
padding: '0 0',
});
static SelectedHighlight = styled.div<{selected: boolean}>(props => ({
static SelectedHighlight = styled.div<{selected: boolean}>((props) => ({
borderColor: colors.highlight,
borderStyle: 'solid',
borderWidth: props.selected ? 3 : 0,
@@ -430,7 +431,7 @@ class ImageItem extends PureComponent<{
}));
static HoverOverlay = styled(FlexColumn)<{selected: boolean; size: number}>(
props => ({
(props) => ({
alignItems: 'center',
backgroundColor: colors.whiteAlpha80,
bottom: props.selected ? 4 : 0,

View File

@@ -47,7 +47,7 @@ export default class ImagesSidebar extends Component<
return (
<div>
{this.renderUri()}
{this.props.events.map(e => (
{this.props.events.map((e) => (
<EventDetails key={e.eventId} event={e} />
))}
</div>
@@ -115,7 +115,7 @@ class EventDetails extends Component<{
<DataDescription
type="number"
value={event.startTime}
setValue={function(path: Array<string>, val: any) {}}
setValue={function (path: Array<string>, val: any) {}}
/>
</p>
<p>
@@ -124,7 +124,7 @@ class EventDetails extends Component<{
<DataDescription
type="number"
value={event.endTime}
setValue={function(path: Array<string>, val: any) {}}
setValue={function (path: Array<string>, val: any) {}}
/>
</p>
<p>
@@ -133,7 +133,7 @@ class EventDetails extends Component<{
<DataDescription
type="string"
value={event.source}
setValue={function(path: Array<string>, val: any) {}}
setValue={function (path: Array<string>, val: any) {}}
/>
</p>
<p>
@@ -162,7 +162,7 @@ class EventDetails extends Component<{
<DataDescription
type="string"
value={viewport.width + 'x' + viewport.height}
setValue={function(path: Array<string>, val: any) {}}
setValue={function (path: Array<string>, val: any) {}}
/>
</p>
);

View File

@@ -15,7 +15,7 @@ const Container = styled(Block)({
marginLeft: '10px',
});
const List = styled(FlexColumn)<{visibleList: boolean}>(props => ({
const List = styled(FlexColumn)<{visibleList: boolean}>((props) => ({
display: props.visibleList ? 'flex' : 'none',
position: 'absolute',
top: '32px',

View File

@@ -145,7 +145,7 @@ export default class FlipperImagesPlugin extends FlipperPlugin<
};
});
const idSet: Set<string> = levels.reduce((acc, level: CacheInfo) => {
level.imageIds.forEach(id => {
level.imageIds.forEach((id) => {
acc.add(id);
});
return acc;
@@ -243,7 +243,7 @@ export default class FlipperImagesPlugin extends FlipperPlugin<
isLeakTrackingEnabled = false,
}: PersistedState): Array<Notification> =>
closeableReferenceLeaks
.filter(_ => isLeakTrackingEnabled)
.filter((_) => isLeakTrackingEnabled)
.map((event: AndroidCloseableReferenceLeakEvent) => ({
id: event.identityHashCode,
title: `Leaked CloseableReference: ${event.className}`,
@@ -288,7 +288,7 @@ export default class FlipperImagesPlugin extends FlipperPlugin<
}
const imageList = images.map((image: CacheInfo) => {
const imageIdList = image.imageIds.filter(imageID => {
const imageIdList = image.imageIds.filter((imageID) => {
const filteredEvents = events.filter((event: ImageEventWithId) => {
const output =
event.attribution &&
@@ -361,7 +361,7 @@ export default class FlipperImagesPlugin extends FlipperPlugin<
updateCaches = (reason: string) => {
debugLog('Requesting images list (reason=' + reason + ')');
this.client.call('listImages').then((response: ImagesListResponse) => {
response.levels.forEach(data =>
response.levels.forEach((data) =>
this.imagePool ? this.imagePool.fetchImages(data.imageIds) : undefined,
);
this.props.setPersistedState({images: response.levels});
@@ -426,7 +426,7 @@ export default class FlipperImagesPlugin extends FlipperPlugin<
}
const maybeImage = this.props.persistedState.imagesMap[selectedImage];
const events = this.props.persistedState.events.filter(e =>
const events = this.props.persistedState.events.filter((e) =>
e.imageIds.includes(selectedImage),
);
return <ImagesSidebar image={maybeImage} events={events} />;