prettier 2
Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d9d3be33b4
commit
fc9ed65762
@@ -48,12 +48,12 @@ const rowMatchesFilters = (filters: Array<Filter>, row: TableBodyRow) =>
|
||||
return true;
|
||||
}
|
||||
})
|
||||
.every(x => x === true);
|
||||
.every((x) => x === true);
|
||||
|
||||
function rowMatchesRegex(values: Array<string>, regex: string): boolean {
|
||||
try {
|
||||
const re = new RegExp(regex);
|
||||
return values.some(x => re.test(x));
|
||||
return values.some((x) => re.test(x));
|
||||
} catch (e) {
|
||||
return false;
|
||||
}
|
||||
@@ -67,7 +67,7 @@ function rowMatchesSearchTerm(
|
||||
if (searchTerm == null || searchTerm.length === 0) {
|
||||
return true;
|
||||
}
|
||||
const rowValues = Object.keys(row.columns).map(key =>
|
||||
const rowValues = Object.keys(row.columns).map((key) =>
|
||||
textContent(row.columns[key].value),
|
||||
);
|
||||
if (row.filterValue != null) {
|
||||
@@ -76,7 +76,7 @@ function rowMatchesSearchTerm(
|
||||
if (isRegex) {
|
||||
return rowMatchesRegex(rowValues, searchTerm);
|
||||
}
|
||||
return rowValues.some(x =>
|
||||
return rowValues.some((x) =>
|
||||
x.toLowerCase().includes(searchTerm.toLowerCase()),
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user