prettier 2
Summary:
Quick notes:
- This looks worse than it is. It adds mandatory parentheses to single argument lambdas. Lots of outrage on Twitter about it, personally I'm {emoji:1f937_200d_2642} about it.
- Space before function, e.g. `a = function ()` is now enforced. I like this because both were fine before.
- I added `eslint-config-prettier` to the config because otherwise a ton of rules conflict with eslint itself.
Close https://github.com/facebook/flipper/pull/915
Reviewed By: jknoxville
Differential Revision: D20594929
fbshipit-source-id: ca1c65376b90e009550dd6d1f4e0831d32cbff03
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d9d3be33b4
commit
fc9ed65762
@@ -22,22 +22,22 @@ const METRO_MESSAGE = ['React Native packager is running', 'Metro is running'];
|
||||
const QUERY_INTERVAL = 5000;
|
||||
|
||||
async function isMetroRunning(): Promise<boolean> {
|
||||
return new Promise(resolve => {
|
||||
return new Promise((resolve) => {
|
||||
// We use Node's http library, rather than fetch api, as the latter cannot supress network errors being shown in the devtools console
|
||||
// which generates a lot of noise
|
||||
http
|
||||
.get(METRO_URL, resp => {
|
||||
.get(METRO_URL, (resp) => {
|
||||
let data = '';
|
||||
resp
|
||||
.on('data', chunk => {
|
||||
.on('data', (chunk) => {
|
||||
data += chunk;
|
||||
})
|
||||
.on('end', () => {
|
||||
const isMetro = METRO_MESSAGE.some(msg => data.includes(msg));
|
||||
const isMetro = METRO_MESSAGE.some((msg) => data.includes(msg));
|
||||
resolve(isMetro);
|
||||
});
|
||||
})
|
||||
.on('error', err => {
|
||||
.on('error', (err) => {
|
||||
console.debug('Could not connect to METRO ' + err);
|
||||
resolve(false);
|
||||
});
|
||||
@@ -79,7 +79,7 @@ async function unregisterDevices(store: Store, logger: Logger) {
|
||||
let archivedDevice: ArchivedDevice | undefined = undefined;
|
||||
const device = store
|
||||
.getState()
|
||||
.connections.devices.find(device => device.serial === METRO_URL);
|
||||
.connections.devices.find((device) => device.serial === METRO_URL);
|
||||
if (device && !device.isArchived) {
|
||||
archivedDevice = device.archive();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user