Centralise logging

Summary:
Centralise connectivity logging into a single place. By having all logs go through a single interface, then it becomes trivial to manipulate them as needed.

In this change, this is not done.

In subsequent diffs, logs will be dispatched via an event and will be visualised in the Connectivity Hub.

Reviewed By: passy

Differential Revision: D47185054

fbshipit-source-id: fb5eab98895be0c8f61fb9a77d3e66d6a8dbcb27

desktop/flipper-server-core/src/devices/ServerDevice.tsx

@@ -58,30 +58,28 @@ export abstract class ServerDevice {
   }
 
   async startScreenCapture(_destination: string): Promise<void> {
-    throw new Error('startScreenCapture not implemented on BaseDevice ');
+    throw new Error('startScreenCapture not implemented');
   }
 
   async stopScreenCapture(): Promise<string> {
-    throw new Error('stopScreenCapture not implemented on BaseDevice ');
+    throw new Error('stopScreenCapture not implemented');
   }
 
   async executeShell(_command: string): Promise<string> {
-    throw new Error('executeShell not implemented on BaseDevice');
+    throw new Error('executeShell not implemented');
   }
 
   async forwardPort(_local: string, _remote: string): Promise<boolean> {
-    throw new Error('forwardPort not implemented on BaseDevice');
+    throw new Error('forwardPort not implemented');
   }
 
-  async clearLogs(): Promise<void> {
-    // no-op on most devices
-  }
+  async clearLogs(): Promise<void> {}
 
   async navigateToLocation(_location: string) {
-    throw new Error('navigateLocation not implemented on BaseDevice');
+    throw new Error('navigateLocation not implemented');
   }
 
   async installApp(_appBundlePath: string): Promise<void> {
-    throw new Error('Install not implemented');
+    throw new Error('installApp not implemented');
   }
 }