Minor improvements
Summary: Some styling fixes and minor improvements in DataTable, used by network plugin: - be able to customise the context menu - be able to customise how entire rows are copied and presented on the clipboard to be able to deviate from the standard JSON - deeplink handling was made async, this gives the plugin the opportunity to first handle initial setup and rendering before trying to jump somewhere which is a typical use case for deeplinking Reviewed By: passy Differential Revision: D27947186 fbshipit-source-id: a56f081d60520c4bc2ad3c547a8ca5b9357e71a1
This commit is contained in:
committed by
Facebook GitHub Bot
parent
ae88f5d200
commit
faf8588097
@@ -402,7 +402,7 @@ test('plugins can receive deeplinks', async () => {
|
||||
});
|
||||
|
||||
expect(plugin.instance.field1.get()).toBe('');
|
||||
plugin.triggerDeepLink('test');
|
||||
await plugin.triggerDeepLink('test');
|
||||
expect(plugin.instance.field1.get()).toBe('test');
|
||||
});
|
||||
|
||||
@@ -424,7 +424,7 @@ test('device plugins can receive deeplinks', async () => {
|
||||
});
|
||||
|
||||
expect(plugin.instance.field1.get()).toBe('');
|
||||
plugin.triggerDeepLink('test');
|
||||
await plugin.triggerDeepLink('test');
|
||||
expect(plugin.instance.field1.get()).toBe('test');
|
||||
});
|
||||
|
||||
@@ -455,7 +455,7 @@ test('plugins can register menu entries', async () => {
|
||||
});
|
||||
|
||||
expect(plugin.instance.counter.get()).toBe(0);
|
||||
plugin.triggerDeepLink('test');
|
||||
await plugin.triggerDeepLink('test');
|
||||
plugin.triggerMenuEntry('createPaste');
|
||||
plugin.triggerMenuEntry('Custom Action');
|
||||
expect(plugin.instance.counter.get()).toBe(4);
|
||||
|
||||
Reference in New Issue
Block a user