Fix bug where client plugins weren't always started

Summary:
Changelog: Fixed issue where occasionally a plugin wouldn't open after starting Flipper

This fixes a long standing issue where rarely Flipper wouldn't show the selected plugin. This turned out to be a raise condition, that was easy to reproduce in the Flipper browser version; if a client register before all the plugins are loaded, the plugins that are enabled for that client, but not loaded yet, will not instantiate and hence not show up. This diff fixes that

Reviewed By: timur-valiev, aigoncharov

Differential Revision: D32987162

fbshipit-source-id: f3179cd9b6f2e4e79d05be1f2236f63acdf50495

desktop/flipper-ui-core/src/dispatcher/handleOpenPluginDeeplink.tsx

@@ -11,7 +11,7 @@ import React from 'react';
 import {Dialog, getFlipperLib} from 'flipper-plugin';
 import {isTest} from 'flipper-common';
 import {getUser} from '../fb-stubs/user';
-import {State, Store} from '../reducers/index';
+import {Store} from '../reducers/index';
 import {checkForUpdate} from '../fb-stubs/checkForUpdate';
 import {getAppVersion} from '../utils/info';
 import {UserNotSignedInError} from 'flipper-common';
@@ -39,6 +39,7 @@ import {
   OpenPluginParams,
 } from '../deeplinkTracking';
 import {getRenderHostInstance} from '../RenderHost';
+import {waitFor} from '../utils/waitFor';
 
 export function parseOpenPluginParams(query: string): OpenPluginParams {
   // 'flipper://open-plugin?plugin-id=graphql&client=facebook&devices=android,ios&chrome=1&payload='
@@ -272,21 +273,6 @@ async function waitForLogin(store: Store) {
   return waitFor(store, (state) => !!state.user?.id);
 }
 
-// make this more reusable?
-function waitFor(
-  store: Store,
-  predicate: (state: State) => boolean,
-): Promise<void> {
-  return new Promise<void>((resolve) => {
-    const unsub = store.subscribe(() => {
-      if (predicate(store.getState())) {
-        unsub();
-        resolve();
-      }
-    });
-  });
-}
-
 async function verifyFlipperIsUpToDate(title: string) {
   if (!isProduction() || isTest()) {
     return;