Ensure that highlight always responds to prevent timeouts

Summary: In a previous diff D32278523 (8764da7c0b) The desktop request was changed from send to call. Call expects a response and not all code paths return a response. Most calls to set highlight are timing out.

Reviewed By: mweststrate

Differential Revision: D38074704

fbshipit-source-id: 6e85416d6b6470efaa177ad1b74420c8237366d5

android/src/main/java/com/facebook/flipper/core/FlipperReceiver.java

@@ -17,9 +17,8 @@ public interface FlipperReceiver {
    * Reciver for a request sent from the Flipper desktop client.
    *
    * @param params Optional set of parameters sent with the request.
-   * @param responder Optional responder for request. Some requests don't warrant a response
-   *     through. In this case the request should be made from the desktop using send() instead of
-   *     call().
+   * @param responder Responder for request, ensure to respond otherwise request will time out on
+   *     the desktop side
    */
   void onReceive(FlipperObject params, FlipperResponder responder) throws Exception;
 }

android/src/main/java/com/facebook/flipper/plugins/inspector/InspectorFlipperPlugin.java

@@ -420,6 +420,8 @@ public class InspectorFlipperPlugin implements FlipperPlugin {
           }
           mHighlightedId = nodeId;
           mHighlightedAlignmentMode = isAlignmentMode;
+
+          responder.success();
         }
       };