jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update react-devtools-core to 3.6.3 to fix React Inspector

Browse Source 
Summary:
It appears that Electron (or the version of Chromium it uses) has a bug that causes a `webview` process to crash if `URL.createObjectURL` is used.

Before releasing `react-devtools-core` 3.5.0, we updated Webpack and the loaders we used. Apparently the version of `style-loader` we now use makes use of the `URL.createObjectURL` API for CSS source maps. This triggers the `webview` crash I mentioned above.

The fix for this is to disable CSS source maps, in which case the loader just uses a `<style>` tag. This diff updates Nuclide to pull in this fixed version.

Reviewed By: bestander

Differential Revision: D16518772

fbshipit-source-id: a779b7d310f869793fa05988d138ce6a46840d8c
This commit is contained in:
Brian Vaughn
2019-07-26 14:41:54 -07:00
committed by Facebook Github Bot
parent e7198040ea
commit f6a4ad59c0
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@@ -105,7 +105,7 @@
"react": "16.8.6", "react": "16.8.6",
"react-color": "^2.11.7", "react-color": "^2.11.7",
"react-debounce-render": "^4.0.3", "react-debounce-render": "^4.0.3",
"react-devtools-core": "^3.6.2", "react-devtools-core": "^3.6.3",
"react-dom": "16.8.6", "react-dom": "16.8.6",
"react-emotion": "^9.2.6", "react-emotion": "^9.2.6",
"react-redux": "^5.0.7", "react-redux": "^5.0.7",

8
yarn.lock
View File

@@ -6490,10 +6490,10 @@ react-debounce-render@^4.0.3:
lodash "^4.17.10" lodash "^4.17.10"
lodash.debounce "^4.0.8" lodash.debounce "^4.0.8"
react-devtools-core@^3.6.2: react-devtools-core@^3.6.3:
version "3.6.2" version "3.6.3"
resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.2.tgz#7d425f160c5928129fa9acdbdd9e80a334e09c8d" resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.3.tgz#977d95b684c6ad28205f0c62e1e12c5f16675814"
integrity sha512-a5r2Er0PajtlvKYBUKzB3vW5qek8TbgQWwRruDEwTm3VnqVffHmnvApRil/lfkAa8ghXcESNizrtKu/18oG55Q== integrity sha512-+P+eFy/yo8Z/UH9J0DqHZuUM5+RI2wl249TNvMx3J2jpUomLQa4Zxl56GEotGfw3PIP1eI+hVf1s53FlUONStQ==
dependencies: dependencies:
shell-quote "^1.6.1" shell-quote "^1.6.1"
ws "^3.3.1" ws "^3.3.1"