From f560f770b64dd4a0f6c9d3ee1fb5b10a0ec60da5 Mon Sep 17 00:00:00 2001 From: Tim Isganitis Date: Thu, 23 Aug 2018 09:11:39 -0700 Subject: [PATCH] Fix iOS screen recording Summary: It looks like the iOS simulator screen recording tool expects a SIGINT instead of a SIGKILL (the default of node's ChildProcess.kill()) to indicate it should stop recording, save the video file and die cleanly. Reviewed By: danielbuechele Differential Revision: D9480678 fbshipit-source-id: 5f17bd288c7622ffa3c337cef311e5e4e462218a --- src/chrome/ScreenCaptureButtons.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chrome/ScreenCaptureButtons.js b/src/chrome/ScreenCaptureButtons.js index ce9cf7eed..715eb8855 100644 --- a/src/chrome/ScreenCaptureButtons.js +++ b/src/chrome/ScreenCaptureButtons.js @@ -232,7 +232,7 @@ class ScreenCaptureButtons extends Component { if (selectedDevice instanceof AndroidDevice) { this.executeShell(selectedDevice, `pgrep 'screenrecord' -L 2`); } else if (this.iOSRecorder && videoPath) { - this.iOSRecorder.kill(); + this.iOSRecorder.kill('SIGINT'); this.setState({ recording: false, });