jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix patch release versioning for open-source version

Browse Source 
Summary: Patch was always set to "0" for open source releases even if it is set to "1" in package.json

Reviewed By: passy

Differential Revision: D26975947

fbshipit-source-id: b3f127c9746797fbb5a79dfcd9bd52210c3a7df8
This commit is contained in:
Anton Nikolaev
2021-03-11 04:30:30 -08:00
committed by Facebook GitHub Bot
parent 11f7af3e72
commit f508a35ff9
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
desktop/scripts/build-release.ts
View File

@@ -72,7 +72,6 @@ const argv = yargs
description:
'Unique build identifier to be used as the version patch part for the build',
type: 'number',
default: 0,
},
channel: {
description: 'Release channel for the build',

8
desktop/scripts/build-utils.ts
View File

@@ -222,10 +222,12 @@ export function buildFolder(): Promise<string> {
return '';
});
}
export function getVersionNumber(buildNumber: number) {
export function getVersionNumber(buildNumber?: number) {
let {version} = require('../package.json');
// Unique build number is passed as --version parameter from Sandcastle
version = [...version.split('.').slice(0, 2), buildNumber].join('.');
if (buildNumber) {
// Unique build number is passed as --version parameter from Sandcastle
version = [...version.split('.').slice(0, 2), buildNumber].join('.');
}
return version;
}