From f506d0eb61d885d8977ed173954ac98bc8a15bf1 Mon Sep 17 00:00:00 2001 From: Anton Nikolaev Date: Tue, 14 Apr 2020 07:10:38 -0700 Subject: [PATCH] Fix auto-format for js files Summary: Auto-format for js files was broken on my machine. It seems that there is a conflict between eslint and prettier and the latter is trying to format files after eslint using different rules for that. Option to disable prettier formatting for already formatted files fixed this issue for me. Reviewed By: jknoxville Differential Revision: D20994053 fbshipit-source-id: 6e90be7f58f2891ce2143bca8c3d76118b9cfba3 --- .vscode/settings.json | 1 + desktop/.vscode/settings.json | 1 + 2 files changed, 2 insertions(+) diff --git a/.vscode/settings.json b/.vscode/settings.json index c2d8ff8bd..511ad9e5f 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -5,6 +5,7 @@ "eslint.packageManager": "yarn", "eslint.codeActionsOnSave.mode": "all", "editor.formatOnSave": true, + "prettier.formatAlreadyFormattedFilesOnSave": false, "files.eol": "\n", "editor.codeActionsOnSave": { "source.fixAll": true diff --git a/desktop/.vscode/settings.json b/desktop/.vscode/settings.json index c2d8ff8bd..511ad9e5f 100644 --- a/desktop/.vscode/settings.json +++ b/desktop/.vscode/settings.json @@ -5,6 +5,7 @@ "eslint.packageManager": "yarn", "eslint.codeActionsOnSave.mode": "all", "editor.formatOnSave": true, + "prettier.formatAlreadyFormattedFilesOnSave": false, "files.eol": "\n", "editor.codeActionsOnSave": { "source.fixAll": true