From f313d5edcb78b0c8e568a7f5cd2bbca3f4912b0e Mon Sep 17 00:00:00 2001 From: Benjamin Elo Date: Tue, 23 Jul 2019 03:22:53 -0700 Subject: [PATCH] Added full screen flex column Summary: The original flex colum that came as standard did not flex to fill the remainder of the screen. Adding this component allows for a full screen flex column so that the scroll bar in the timeline looks correct. Reviewed By: jknoxville Differential Revision: D16416933 fbshipit-source-id: bd296aea85730f192778ed0aca4b226893b2829d --- .../navigation/components/ScrollableFlexColumn.js | 13 +++++++++++++ src/plugins/navigation/components/index.js | 1 + src/plugins/navigation/index.js | 8 ++++---- 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 src/plugins/navigation/components/ScrollableFlexColumn.js diff --git a/src/plugins/navigation/components/ScrollableFlexColumn.js b/src/plugins/navigation/components/ScrollableFlexColumn.js new file mode 100644 index 000000000..6db3dfd52 --- /dev/null +++ b/src/plugins/navigation/components/ScrollableFlexColumn.js @@ -0,0 +1,13 @@ +/** + * Copyright 2018-present Facebook. + * This source code is licensed under the MIT license found in the + * LICENSE file in the root directory of this source tree. + * @format + * @flow strict-local + */ + +import {FlexColumn, styled} from 'flipper'; + +export default styled(FlexColumn)({ + height: '100%', +}); diff --git a/src/plugins/navigation/components/index.js b/src/plugins/navigation/components/index.js index 907d8c41e..cd31576e9 100644 --- a/src/plugins/navigation/components/index.js +++ b/src/plugins/navigation/components/index.js @@ -8,4 +8,5 @@ export {default as IconButton} from './IconButton'; export {default as NavigationInfoBox} from './NavigationInfoBox'; +export {default as ScrollableFlexColumn} from './ScrollableFlexColumn'; export {default as SearchBar} from './SearchBar'; diff --git a/src/plugins/navigation/index.js b/src/plugins/navigation/index.js index 13f9d0229..f3cee844c 100644 --- a/src/plugins/navigation/index.js +++ b/src/plugins/navigation/index.js @@ -6,8 +6,8 @@ * @flow strict-local */ -import {FlipperPlugin, FlexColumn} from 'flipper'; -import {SearchBar} from './components'; +import {FlipperPlugin} from 'flipper'; +import {SearchBar, ScrollableFlexColumn} from './components'; type State = {||}; @@ -70,12 +70,12 @@ export default class extends FlipperPlugin { render() { return ( - + {}} /> - + ); } }