Fixed circular dependencies

Summary: Fixed circular dependency warnings and removed some dead code while at it.

Reviewed By: jknoxville

Differential Revision: D20557313

fbshipit-source-id: 856c42113a9abe36d3e14f9d538eb40705ceb87f

desktop/app/src/reducers/connections.tsx

@@ -466,10 +466,15 @@ export const selectDevice = (payload: BaseDevice): Action => ({
   payload,
 });
 
-export const setStaticView = (payload: StaticView): Action => ({
-  type: 'SET_STATIC_VIEW',
-  payload,
-});
+export const setStaticView = (payload: StaticView): Action => {
+  if (!payload) {
+    throw new Error('Cannot set empty static view');
+  }
+  return {
+    type: 'SET_STATIC_VIEW',
+    payload,
+  };
+};
 
 export const preferDevice = (payload: string): Action => ({
   type: 'PREFER_DEVICE',

desktop/app/src/reducers/supportForm.tsx

@@ -9,7 +9,6 @@
 
 import {Actions, Store} from './';
 import {setStaticView} from './connections';
-import SupportRequestFormV2 from '../fb-stubs/SupportRequestFormV2';
 import {deconstructClientId} from '../utils/clientUtils';
 import {starPlugin as setStarPlugin} from './connections';
 import {showStatusUpdatesForDuration} from '../utils/promiseTimeout';
@@ -114,7 +113,9 @@ export class Group {
       source: 'deeplink',
       group: this.name,
     });
-    store.dispatch(setStaticView(SupportRequestFormV2));
+    store.dispatch(
+      setStaticView(require('../fb-stubs/SupportRequestFormV2').default),
+    );
     const selectedApp = store.getState().connections.selectedApp;
     const selectedClient = store.getState().connections.clients.find(o => {
       return o.id === store.getState().connections.selectedApp;

desktop/app/src/ui/components/elements-inspector/Visualizer.tsx

@@ -9,7 +9,8 @@
 
 import React from 'react';
 import ReactDOM from 'react-dom';
-import {Element, styled} from '../../../ui';
+import {Element} from './ElementsInspector';
+import styled from '@emotion/styled';
 
 export function VisualizerPortal(props: {
   container: HTMLElement;