diff --git a/desktop/flipper-server-core/src/comms/ServerController.tsx b/desktop/flipper-server-core/src/comms/ServerController.tsx index b61a0a0d7..79c09baac 100644 --- a/desktop/flipper-server-core/src/comms/ServerController.tsx +++ b/desktop/flipper-server-core/src/comms/ServerController.tsx @@ -277,13 +277,15 @@ export class ServerController } onConnectionAttempt(clientQuery: ClientQuery): void { - // TODO: track plain connection attempt. const strippedClientQuery = (({device_id, ...o}) => o)(clientQuery); const id = buildClientId({device_id: 'unknown', ...strippedClientQuery}); this.timestamps.set(id, { insecureStart: Date.now(), }); this.logger.track('usage', 'untrusted-request-handler-called', clientQuery); + + tracker.track('app-connection-insecure-attempt', clientQuery); + this.connectionTracker.logConnectionAttempt(clientQuery); const client: UninitializedClient = { diff --git a/desktop/flipper-server-core/src/utils/tracker.tsx b/desktop/flipper-server-core/src/utils/tracker.tsx index 1a8c38a4c..9cf1bbed5 100644 --- a/desktop/flipper-server-core/src/utils/tracker.tsx +++ b/desktop/flipper-server-core/src/utils/tracker.tsx @@ -14,7 +14,7 @@ type AppConnectionPayload = { os: string; device: string; device_id: string; - medium: number | undefined; + medium?: number | undefined; }; type TrackerEvents = { @@ -28,6 +28,7 @@ type TrackerEvents = { 'server-proxy-error': {error: string}; 'app-connection-created': AppConnectionPayload; 'app-connection-secure-attempt': AppConnectionPayload; + 'app-connection-insecure-attempt': AppConnectionPayload; }; class ServerCoreTracker {