Fixed issue where visualiser would crop bottom few pixels of screen
Summary: Fixes https://fb.workplace.com/groups/443457641253219/permalink/522118536720462/ On android for some reason our display metrics for the application, activity and winow were smaller than the decor view. We were using the root view as the base static view for the visualiser with overflow hidden. Since it will slightly smaller than the decor view we were losing some of the lower pixels of the snapshot The decor view is the one that is actually snapshot so any bounds for nodes above are meaningless . The fix is to simply have the visualiser start at the snapshot view. We know this bounds is correct. Tested on ios and android and all looks ok Reviewed By: lblasa Differential Revision: D43356523 fbshipit-source-id: 4d6177c8242365f33b1d64fc149a10baff7c85d6
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d24343d2ac
commit
f12d8221d6
@@ -63,7 +63,6 @@ export function Component() {
|
||||
gutter>
|
||||
<Layout.ScrollContainer vertical>
|
||||
<Visualization2D
|
||||
rootId={rootId}
|
||||
width={visualiserWidth}
|
||||
nodes={nodes}
|
||||
onSelectNode={instance.uiActions.onSelectNode}
|
||||
|
||||
Reference in New Issue
Block a user