Use fragments instead of arrays when returning elements
Summary: Returning arrays from render kills react-reconciliation and produces missing key warnings. Turned all array rendering methods to use Fragments, where I could find them. Reviewed By: jknoxville Differential Revision: D21178253 fbshipit-source-id: 85ddf8adfa79732ccbe68409fdcf150399455983
This commit is contained in:
committed by
Facebook GitHub Bot
parent
67412bfb43
commit
f07d898a35
@@ -188,20 +188,22 @@ function renderToolbar(section: ToolbarSection) {
|
||||
</Button>
|
||||
);
|
||||
case 'input':
|
||||
return [
|
||||
<Label>{item.label}</Label>,
|
||||
<Select
|
||||
options={item.options.reduce(
|
||||
(obj: {[key: string]: string}, item) => {
|
||||
obj[item] = item;
|
||||
return obj;
|
||||
},
|
||||
{},
|
||||
)}
|
||||
selected={item.value}
|
||||
onChange={() => {}}
|
||||
/>,
|
||||
];
|
||||
return (
|
||||
<>
|
||||
<Label>{item.label}</Label>
|
||||
<Select
|
||||
options={item.options.reduce(
|
||||
(obj: {[key: string]: string}, item) => {
|
||||
obj[item] = item;
|
||||
return obj;
|
||||
},
|
||||
{},
|
||||
)}
|
||||
selected={item.value}
|
||||
onChange={() => {}}
|
||||
/>
|
||||
</>
|
||||
);
|
||||
}
|
||||
});
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user