jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add missing @Nullable annotations

Browse Source 
Summary: Native can return nullptr, so this should be annotated.

Reviewed By: jknoxville

Differential Revision: D15146700

fbshipit-source-id: 332e3a074d2e39cfff677f3d84e94f910563f992
This commit is contained in:
Pascal Hartig
2019-04-30 13:08:52 -07:00
committed by Facebook Github Bot
parent b3ec8b052b
commit ef46dd7f91
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/src/main/java/com/facebook/flipper/android/FlipperClientImpl.java
View File

@@ -16,6 +16,7 @@ import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.soloader.SoLoader; import com.facebook.soloader.SoLoader;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import javax.annotation.Nullable;
@DoNotStrip @DoNotStrip
class FlipperClientImpl implements FlipperClient { class FlipperClientImpl implements FlipperClient {
@@ -59,9 +60,11 @@ class FlipperClientImpl implements FlipperClient {
* @deprecated Prefer using {@link #getPluginByClass(Class)} over the stringly-typed interface. * @deprecated Prefer using {@link #getPluginByClass(Class)} over the stringly-typed interface.
*/ */
@Override @Override
@Nullable
@Deprecated @Deprecated
public native <T extends FlipperPlugin> T getPlugin(String id); public native <T extends FlipperPlugin> T getPlugin(String id);
@Nullable
@Override @Override
public <T extends FlipperPlugin> T getPluginByClass(Class<T> cls) { public <T extends FlipperPlugin> T getPluginByClass(Class<T> cls) {
final String id = mClassIdentifierMap.get(cls); final String id = mClassIdentifierMap.get(cls);

4
android/src/main/java/com/facebook/flipper/core/FlipperClient.java
View File

@@ -7,11 +7,15 @@
*/ */
package com.facebook.flipper.core; package com.facebook.flipper.core;
import javax.annotation.Nullable;
public interface FlipperClient { public interface FlipperClient {
void addPlugin(FlipperPlugin plugin); void addPlugin(FlipperPlugin plugin);
@Nullable
<T extends FlipperPlugin> T getPlugin(String id); <T extends FlipperPlugin> T getPlugin(String id);
@Nullable
<T extends FlipperPlugin> T getPluginByClass(Class<T> cls); <T extends FlipperPlugin> T getPluginByClass(Class<T> cls);
void removePlugin(FlipperPlugin plugin); void removePlugin(FlipperPlugin plugin);