From ef091e7a070d1146ea5ffdda5f4a1715a81acf8f Mon Sep 17 00:00:00 2001
From: Anton Nikolaev <nikoant@fb.com>
Date: Tue, 11 May 2021 17:02:24 -0700
Subject: [PATCH] Allow specifying min required Flipper version on
 "build-plugin" command call

Summary: Added an arg for "build-plugin" command to easily set min required flipper version when plugin is packaged. Before that we only saved engine version in Marketplace metadata, but it's better to save it into the package as well, so we can check compatibility for installed packages even when we have no Marketplace metadata for them.

Reviewed By: passy

Differential Revision: D28350276

fbshipit-source-id: 916d891540263a1f99c1f6d2033eb13e1c36d78f
---
 desktop/scripts/build-plugin.ts | 39 +++++++++++++++++++++++++++------
 1 file changed, 32 insertions(+), 7 deletions(-)

diff --git a/desktop/scripts/build-plugin.ts b/desktop/scripts/build-plugin.ts
index 6b77b2b42..c2aa8aac3 100644
--- a/desktop/scripts/build-plugin.ts
+++ b/desktop/scripts/build-plugin.ts
@@ -7,13 +7,14 @@
  * @format
  */
 
-import {pluginsDir, rootDir, distDir} from './paths';
+import {pluginsDir, distDir, rootDir} from './paths';
 import path from 'path';
 import fs from 'fs-extra';
-import {execSync} from 'child_process';
 import {resolvePluginDir} from './workspaces';
 import {runBuild, computePackageChecksum} from 'flipper-pkg-lib';
 import yargs from 'yargs';
+import tmp from 'tmp';
+import {execSync} from 'child_process';
 
 const argv = yargs
   .usage('yarn build-plugin [args]')
@@ -31,6 +32,11 @@ const argv = yargs
       type: 'string',
       alias: 'v',
     },
+    'min-flipper-version': {
+      description: 'Minimum Flipper version required for plugin',
+      type: 'string',
+      alias: 'mfv',
+    },
     checksum: {
       description:
         'Checksum of the previous plugin package which is used to determine whether the plugin is changed or not. If it is not changed, it will not be packaged.',
@@ -52,6 +58,8 @@ async function buildPlugin() {
   const previousChecksum = argv.checksum;
   const pluginDir = await resolvePluginDir(pluginName);
   const outputFileArg = argv.output;
+  const minFlipperVersion = argv['min-flipper-version'];
+  const packageJsonPath = path.join(pluginDir, 'package.json');
   await runBuild(pluginDir, false);
   const checksum = await computePackageChecksum(pluginDir);
   if (previousChecksum !== checksum && argv.version) {
@@ -65,10 +73,27 @@ async function buildPlugin() {
         );
     await fs.ensureDir(path.dirname(outputFile));
     await fs.remove(outputFile);
-    const versionCmd = `yarn version --cwd "${pluginDir}" --new-version ${argv.version}`;
-    execSync(versionCmd, {cwd: rootDir, stdio: 'inherit'});
-    const packCmd = `yarn pack --cwd "${pluginDir}" --filename ${outputFile}`;
-    execSync(packCmd, {cwd: rootDir, stdio: 'inherit'});
+    const {name: tmpDir} = tmp.dirSync();
+    const packageJsonBackupPath = path.join(tmpDir, 'package.json');
+    await fs.copy(packageJsonPath, packageJsonBackupPath, {overwrite: true});
+    try {
+      const packageJson = await fs.readJson(packageJsonPath);
+      if (minFlipperVersion) {
+        if (!packageJson.engines) {
+          packageJson.engines = {};
+        }
+        packageJson.engines.flipper = minFlipperVersion;
+      }
+      if (argv.version) {
+        packageJson.version = argv.version;
+      }
+      await fs.writeJson(packageJsonPath, packageJson, {spaces: 2});
+      const packCmd = `yarn pack --cwd "${pluginDir}" --filename ${outputFile}`;
+      execSync(packCmd, {cwd: rootDir, stdio: 'inherit'});
+    } finally {
+      await fs.move(packageJsonBackupPath, packageJsonPath, {overwrite: true});
+      await fs.remove(tmpDir);
+    }
     await fs.writeFile(outputFile + '.hash', checksum);
   }
 }
@@ -78,6 +103,6 @@ buildPlugin()
     process.exit(0);
   })
   .catch((err: any) => {
-    console.error(err);
+    console.error(`Error while building plugin ${argv.plugin}`, err);
     process.exit(1);
   });