jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Track time for URL exports

Browse Source 
Summary: Per title.

Reviewed By: jknoxville

Differential Revision: D15939231

fbshipit-source-id: edf6c854298b52d777cda56df14f268814fba9d2
This commit is contained in:
Pascal Hartig
2019-06-21 06:29:53 -07:00
committed by Facebook Github Bot
parent 58c66a626d
commit eea7e1830b
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/App.js
View File

@@ -78,7 +78,7 @@ export class App extends React.Component<Props> {
case ACTIVE_SHEET_PLUGIN_DEBUGGER: case ACTIVE_SHEET_PLUGIN_DEBUGGER:
return <PluginDebugger onHide={onHide} />; return <PluginDebugger onHide={onHide} />;
case ACTIVE_SHEET_SHARE_DATA: case ACTIVE_SHEET_SHARE_DATA:
return <ShareSheet onHide={onHide} />; return <ShareSheet onHide={onHide} logger={this.props.logger} />;
case ACTIVE_SHEET_SIGN_IN: case ACTIVE_SHEET_SIGN_IN:
return <SignInSheet onHide={onHide} />; return <SignInSheet onHide={onHide} />;
case ACTIVE_SHEET_SHARE_DATA_IN_FILE: case ACTIVE_SHEET_SHARE_DATA_IN_FILE:

9
src/chrome/ShareSheet.js
View File

@@ -17,11 +17,14 @@ import {
Spacer, Spacer,
Input, Input,
} from 'flipper'; } from 'flipper';
import type {Logger} from '../fb-interfaces/Logger.js';
import {shareFlipperData} from '../fb-stubs/user'; import {shareFlipperData} from '../fb-stubs/user';
import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData.js'; import {exportStore, EXPORT_FLIPPER_TRACE_EVENT} from '../utils/exportData.js';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import {clipboard} from 'electron'; import {clipboard} from 'electron';
import {reportPlatformFailures} from '../utils/metrics'; import {reportPlatformFailures} from '../utils/metrics';
// $FlowFixMe: Missing type defs for node built-in.
import {performance} from 'perf_hooks';
export const SHARE_FLIPPER_TRACE_EVENT = 'share-flipper-link'; export const SHARE_FLIPPER_TRACE_EVENT = 'share-flipper-link';
const Container = styled(FlexColumn)({ const Container = styled(FlexColumn)({
@@ -72,6 +75,7 @@ const Padder = styled('div')(
type Props = { type Props = {
onHide: () => mixed, onHide: () => mixed,
logger: Logger,
}; };
type State = { type State = {
errorArray: Array<Error>, errorArray: Array<Error>,
@@ -96,6 +100,8 @@ export default class ShareSheet extends Component<Props, State> {
}; };
async componentDidMount() { async componentDidMount() {
const mark = 'shareSheetExportUrl';
performance.mark(mark);
try { try {
const {serializedString, errorArray} = await reportPlatformFailures( const {serializedString, errorArray} = await reportPlatformFailures(
exportStore(this.context.store), exportStore(this.context.store),
@@ -115,6 +121,7 @@ export default class ShareSheet extends Component<Props, State> {
requireInteraction: true, requireInteraction: true,
}); });
} }
this.props.logger.trackTimeSince(mark, 'export:url-success');
} catch (e) { } catch (e) {
this.setState({ this.setState({
result: { result: {
@@ -122,7 +129,7 @@ export default class ShareSheet extends Component<Props, State> {
error: e, error: e,
}, },
}); });
return; this.props.logger.trackTimeSince(mark, 'export:url-error');
} }
} }