Extract logger and write to file

Summary:
This change extracts logging logic out from startFlipperServer.

Logs will also be written to disk.

Reviewed By: passy

Differential Revision: D36473768

fbshipit-source-id: b1df9df79b4aced0d3ba2e8c243aa8d44cf83703

desktop/flipper-server/src/startFlipperServer.tsx

@@ -16,12 +16,7 @@ import {
   loadSettings,
   getEnvironmentInfo,
 } from 'flipper-server-core';
-import {
-  parseEnvironmentVariables,
-  isTest,
-  Logger,
-  setLoggerInstance,
-} from 'flipper-common';
+import {parseEnvironmentVariables, isTest, getLogger} from 'flipper-common';
 import path from 'path';
 import fs from 'fs-extra';
 
@@ -53,9 +48,6 @@ export async function startFlipperServer(
     desktopPath = os.homedir();
   }
 
-  const logger = createLogger();
-  setLoggerInstance(logger);
-
   let keytar: any = undefined;
   try {
     if (!isTest()) {
@@ -96,35 +88,7 @@ export async function startFlipperServer(
       settings: await loadSettings(settingsString),
       validWebSocketOrigins: ['localhost:', 'http://localhost:'],
     },
-    logger,
+    getLogger(),
     keytar,
   );
 }
-
-function createLogger(): Logger {
-  return {
-    track(..._args: [any, any, any?, any?]) {
-      // TODO: only if verbose console.debug(...args);
-      // console.warn('(skipper track)', args);
-    },
-    trackTimeSince(..._args: [any, any, any?]) {
-      // TODO: only if verbose console.debug(...args);
-      // console.warn('(skipped trackTimeSince)', args);
-    },
-    debug(..._args: any[]) {
-      // TODO: only if double verbose console.debug(...args);
-    },
-    error(...args: any[]) {
-      console.error(...args);
-      console.warn('(skipped error reporting)');
-    },
-    warn(...args: any[]) {
-      console.warn(...args);
-      console.warn('(skipped error reporting)');
-    },
-    info(..._args: any[]) {
-      // TODO: only if  verbose console.debug(...args);
-      // console.info(...args);
-    },
-  };
-}