jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add sessionId to itsr query string

Browse Source 
Summary: This will allow rating data to be joined with version number so we can get the rating of each release.

Reviewed By: mweststrate

Differential Revision: D18297808

fbshipit-source-id: 00f151c64aad40632389f728ad25a565f44a2a90
This commit is contained in:
John Knox
2019-11-04 09:22:18 -08:00
committed by Facebook Github Bot
parent b2cf34bc2f
commit ed2343b3c6
2 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/fb-stubs/UserFeedback.tsx
View File

@@ -18,7 +18,10 @@ export type FeedbackPrompt = {
shouldPopup: boolean;
};
export async function submitRating(rating: number): Promise<void> {
export async function submitRating(
rating: number,
sessionId: string | null,
): Promise<void> {
throw new Error('Method not implemented.');
}
export async function submitComment(
@@ -26,10 +29,11 @@ export async function submitComment(
comment: string,
selectedPredefinedComments: string[],
allowUserInfoSharing: boolean,
sessionId: string | null,
): Promise<void> {
throw new Error('Method not implemented.');
}
export async function dismiss(): Promise<void> {
export async function dismiss(sessionId: string | null): Promise<void> {
throw new Error('Method not implemented.');
}
export async function getPrompt(): Promise<FeedbackPrompt> {