Fix most lint warnings

Summary:
I noticed that after the typescript upgrade, I got several weird positives from ESLint (like unused parameters in a type definition, which are obviously always unused, e.g. `type onClick = (e: Event) => void`). After some investigation, it turned out these warnings are generated by eslint, but that those rules should be performaned by typescript/eslint instead. For future reference to which rules this applies:

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md#extension-rules

Updated the config, and while at it, fixed all warnings in our codebase, except for `react-hooks/exhaustive-deps` warnings, since those require semantic changes.

This reduces the amount of eslint warnings from 86 to 39.

Reviewed By: passy

Differential Revision: D23905630

fbshipit-source-id: 0557708fd9ec6b17840a3c191e7d3baf225bdf23

desktop/plugins/crash_reporter/index.tsx

@@ -387,7 +387,7 @@ function addFileWatcherForiOSCrashLogs(
     // Directory doesn't exist
     return;
   }
-  fs.watch(dir, (eventType, filename) => {
+  fs.watch(dir, (_eventType, filename) => {
     // We just parse the crash logs with extension `.crash`
     const checkFileExtension = /.crash$/.exec(filename);
     if (!filename || !checkFileExtension) {
@@ -643,7 +643,7 @@ export default class CrashReporterPlugin extends FlipperDevicePlugin<
       const referenceDate = new Date();
       (function (
         store: Store,
-        date: Date,
+        _date: Date,
         setPersistedState: (
           pluginKey: string,
           newPluginState: Maybe<PersistedState>,

desktop/plugins/fresco/ImagesCacheOverview.tsx

@@ -20,7 +20,6 @@ import {
   FlexColumn,
   LoadingIndicator,
   styled,
-  Select,
   ToggleButton,
   Text,
 } from 'flipper';
@@ -96,13 +95,6 @@ type ImagesCacheOverviewState = {
   size: number;
 };
 
-const _StyledSelect = styled(Select)({
-  marginLeft: 6,
-  marginRight: 6,
-  height: '100%',
-  maxWidth: 164,
-});
-
 export default class ImagesCacheOverview extends PureComponent<
   ImagesCacheOverviewProps,
   ImagesCacheOverviewState

desktop/plugins/fresco/index.tsx

@@ -79,12 +79,6 @@ const debugLog = (...args: any[]) => {
   }
 };
 
-type ImagesMetaData = {
-  levels: ImagesListResponse;
-  events: Array<ImageEventWithId>;
-  imageDataList: Array<ImageData>;
-};
-
 export default class FlipperImagesPlugin extends FlipperPlugin<
   PluginState,
   BaseAction,

desktop/plugins/kaios-allocations/types/firefox-client.d.tsx

@@ -43,7 +43,5 @@ declare module 'firefox-client/lib/client-methods' {
 }
 
 declare module 'firefox-client/lib/extend' {
-  import FirefoxClient from 'firefox-client';
-
   export default function extend(prototype: any, o: any): any;
 }

desktop/plugins/network/RequestDetails.tsx

@@ -553,7 +553,7 @@ class JSONTextFormatter {
     );
   };
 
-  formatResponse = (request: Request, response: Response) => {
+  formatResponse = (_request: Request, response: Response) => {
     return this.format(
       decodeBody(response),
       getHeaderValue(response.headers, 'content-type'),
@@ -589,7 +589,7 @@ class XMLTextFormatter {
     );
   };
 
-  formatResponse = (request: Request, response: Response) => {
+  formatResponse = (_request: Request, response: Response) => {
     return this.format(
       decodeBody(response),
       getHeaderValue(response.headers, 'content-type'),
@@ -611,7 +611,7 @@ class JSONFormatter {
     );
   };
 
-  formatResponse = (request: Request, response: Response) => {
+  formatResponse = (_request: Request, response: Response) => {
     return this.format(
       decodeBody(response),
       getHeaderValue(response.headers, 'content-type'),
@@ -715,7 +715,7 @@ class GraphQLFormatter {
     }
   };
 
-  formatResponse = (request: Request, response: Response) => {
+  formatResponse = (_request: Request, response: Response) => {
     return this.format(
       decodeBody(response),
       getHeaderValue(response.headers, 'content-type'),

desktop/plugins/reactdevtools/index.tsx

@@ -85,7 +85,7 @@ const GrabMetroDevice = connect<
 }: GrabMetroDeviceStoreProps & GrabMetroDeviceOwnProps) {
   useEffect(() => {
     onHasDevice(metroDevice);
-  }, [metroDevice]);
+  }, [metroDevice, onHasDevice]);
   return null;
 });