jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clients to avoid sending payloads larger than the maximum allowed size

Browse Source 
Summary: ^

Reviewed By: passy

Differential Revision: D48645400

fbshipit-source-id: ac262296f113298812803c12eccf5a37da1da2b7
This commit is contained in:
Lorenzo Blasa
2023-08-24 10:05:17 -07:00
committed by Facebook GitHub Bot
parent 865d551f8e
commit ecc50f47e8
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/src/main/cpp/sonar.cpp
View File

@@ -343,6 +343,13 @@ class JFlipperWebSocket : public facebook::flipper::FlipperSocket {
if (socket_ == nullptr) { if (socket_ == nullptr) {
return; return;
} }
// Ensure the payload size is valid before sending.
// The maximum allowed size for a message payload is 2^53 - 1. But that is
// for the entire message, including any additional metadata.
if (message.length() > pow(2, 53) - 1) {
throw std::length_error("Payload is too big to send");
}
socket_->send(message); socket_->send(message);
completion(); completion();
} }

8
iOS/FlipperKit/FlipperWebSocket.mm
View File

@@ -121,6 +121,14 @@ void FlipperWebSocket::send(
if (socket_ == NULL) { if (socket_ == NULL) {
return; return;
} }
// Ensure the payload size is valid before sending.
// The maximum allowed size for a message payload is 2^53 - 1. But that is
// for the entire message, including any additional metadata.
if (message.length() > pow(2, 53) - 1) {
throw std::length_error("Payload is too big to send");
}
NSString* messageObjc = [NSString stringWithUTF8String:message.c_str()]; NSString* messageObjc = [NSString stringWithUTF8String:message.c_str()];
[socket_ send:messageObjc [socket_ send:messageObjc
withCompletionHandler:^(NSError*) { withCompletionHandler:^(NSError*) {