Fix Scroll to Left on When Element Inspected in Middle
Summary: `scrollTo` used there caused the window to scroll to the most left when a user was inspecting an element which horizontal scroll wasn't in the most left position. This diff removes the horizontal constrain and only scroll vertically. Reviewed By: mweststrate Differential Revision: D23284227 fbshipit-source-id: 7c19cac7496927c631572e222cb1d635dd1f8ea4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
f4c36377df
commit
ecc3a280cf
@@ -687,15 +687,14 @@ export class Elements extends PureComponent<ElementsProps, ElementsState> {
|
|||||||
this.setState({scrolledElement: selected});
|
this.setState({scrolledElement: selected});
|
||||||
const outer = this._outerRef.current;
|
const outer = this._outerRef.current;
|
||||||
if (outer.scrollTo) {
|
if (outer.scrollTo) {
|
||||||
outer.scrollTo(
|
outer.scrollTo({
|
||||||
0,
|
top: this._calculateScrollTop(
|
||||||
this._calculateScrollTop(
|
|
||||||
outer.offsetHeight,
|
outer.offsetHeight,
|
||||||
outer.scrollTop,
|
outer.scrollTop,
|
||||||
selectedRow.offsetHeight,
|
selectedRow.offsetHeight,
|
||||||
selectedRow.offsetTop,
|
selectedRow.offsetTop,
|
||||||
),
|
),
|
||||||
);
|
});
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
: null
|
: null
|
||||||
|
|||||||
Reference in New Issue
Block a user