Avoid template copy

Summary:
As mentioned on the previous diff, we no longer use a pre-built template when creating a release build.

This change moves the built binary directly into place instead of updating the existing template after which it was moved to its final destination.

Reviewed By: antonk52

Differential Revision: D51424944

fbshipit-source-id: 284fb53bb5f00f92b3ca9db3b28cfd1e4dacfa19

desktop/scripts/build-flipper-server-release.tsx

@@ -744,7 +744,6 @@ async function setUpMacBundle(
 ): Promise<{nodePath: string; resourcesPath: string}> {
   console.log(`⚙️  Creating Mac bundle in ${outputDir}`);
 
-  let appTemplate = path.join(staticDir, 'flipper-server-app-template');
   if (isFB) {
     const {BuildArchitecture, buildFlipperServer} = await import(
       // @ts-ignore only used inside Meta
@@ -760,19 +759,15 @@ async function setUpMacBundle(
       `⚙️  Successfully built platform: ${platform}, output: ${outputPath}`,
     );
 
-    appTemplate = path.join(
-      staticDir,
-      'facebook',
-      'flipper-server-app-template',
-      platform,
-    );
+    const appPath = path.join(outputDir, 'Flipper.app');
+    await fs.emptyDir(appPath);
 
-    await fs.copy(outputPath, path.join(appTemplate, 'Flipper.app'));
-    console.info('⚙️  Using internal template from: ' + appTemplate);
+    await fs.copy(outputPath, appPath);
+  } else {
+    const template = path.join(staticDir, 'flipper-server-app-template');
+    await fs.copy(template, outputDir);
   }
 
-  await fs.copy(appTemplate, outputDir);
-
   function replacePropertyValue(
     obj: any,
     targetValue: string,