jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed the patch disabling warnings for cyclic dependencies inside node_modules

Browse Source 
Summary: Fixed the patch disabling warnings for cyclic dependencies inside node_modules. It broke after I changed the way of bundling plugins.

Reviewed By: passy

Differential Revision: D21065488

fbshipit-source-id: f8891f007d14d2475df517b28452dc0b8346f113
This commit is contained in:
Anton Nikolaev
2020-04-16 09:49:56 -07:00
committed by Facebook GitHub Bot
parent a1919bc4ef
commit ec7cbd7f14
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/patches/metro+0.59.0.patch
View File

@@ -1,5 +1,5 @@
diff --git a/node_modules/metro/src/lib/polyfills/require.js b/node_modules/metro/src/lib/polyfills/require.js diff --git a/node_modules/metro/src/lib/polyfills/require.js b/node_modules/metro/src/lib/polyfills/require.js
index 8c04756..56c0d34 100644 index 8c04756..3610bba 100644
--- a/node_modules/metro/src/lib/polyfills/require.js --- a/node_modules/metro/src/lib/polyfills/require.js
+++ b/node_modules/metro/src/lib/polyfills/require.js +++ b/node_modules/metro/src/lib/polyfills/require.js
@@ -114,11 +114,13 @@ function metroRequire(moduleId) { @@ -114,11 +114,13 @@ function metroRequire(moduleId) {
@@ -11,7 +11,7 @@ index 8c04756..56c0d34 100644
- "Require cycles are allowed, but can result in uninitialized values. " + - "Require cycles are allowed, but can result in uninitialized values. " +
- "Consider refactoring to remove the need for a cycle." - "Consider refactoring to remove the need for a cycle."
- ); - );
+ if (!cycle[0].startsWith('node_modules/')) { + if (!cycle.every(path => path.includes('/node_modules/'))) {
+ console.warn( + console.warn(
+ `Require cycle: ${cycle.join(" -> ")}\n\n` + + `Require cycle: ${cycle.join(" -> ")}\n\n` +
+ "Require cycles are allowed, but can result in uninitialized values. " + + "Require cycles are allowed, but can result in uninitialized values. " +