Linter checks for extraneous dependencies

Summary: Added eslint rule "no-extraneous-imports" which disallow using modules which are not listed as dependencies in the corresponding package.json. Fixed a bunch of reported errors after the rule applied.

Reviewed By: passy

Differential Revision: D21186848

fbshipit-source-id: 0af9ac4b3fffdfd0ab7c23ae4ff12a3f5989d5e9

desktop/plugins/layout/Inspector.tsx

@@ -15,7 +15,7 @@ import {
   ElementSearchResultSet,
 } from 'flipper';
 import {Component} from 'react';
-import debounce from 'lodash.debounce';
+import {debounce} from 'lodash';
 import {PersistedState, ElementMap} from './';
 import React from 'react';
 

desktop/plugins/layout/ProxyArchiveClient.tsx

@@ -10,7 +10,7 @@
 import {Element} from 'flipper';
 import {PersistedState} from './index';
 import {SearchResultTree} from './Search';
-import cloneDeep from 'lodash.clonedeep';
+import {cloneDeep} from 'lodash';
 
 const propsForPersistedState = (
   AXMode: boolean,

desktop/plugins/layout/package.json

@@ -8,17 +8,12 @@
   ],
   "dependencies": {
     "deep-equal": "^2.0.1",
-    "lodash": "^4.17.15",
-    "lodash.clonedeep": "^4.5.0",
-    "lodash.debounce": "^4.0.8"
+    "lodash": "^4.17.15"
   },
   "title": "Layout",
   "icon": "target",
   "bugs": {
     "email": "oncall+flipper@xmail.facebook.com",
     "url": "https://fb.workplace.com/groups/flippersupport/"
-  },
-  "devDependencies": {
-    "@types/lodash.clonedeep": "^4.5.6"
   }
 }