jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Left some code comments

Browse Source 
Summary: Added some additional code comments as requested in earlier diffs

Reviewed By: passy

Differential Revision: D33361691

fbshipit-source-id: 2d1adc8830af58e6cb7bac4b283a5c0171cf749e
This commit is contained in:
Michel Weststrate
2022-01-04 09:05:09 -08:00
committed by Facebook GitHub Bot
parent d92c403dd2
commit ebc4752077
4 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
desktop/scripts/build-utils.ts
View File

@@ -477,6 +477,11 @@ export async function buildBrowserBundle(outDir: string, dev: boolean) {
if (moduleName === 'flipper') {
return MetroResolver.resolve(context, 'flipper-ui-core', ...rest);
}
// stubbed modules are modules that don't make sense outside a Node / Electron context,
// like fs, child_process etc etc.
// UI / plugins using these features should use the corresponding RenderHost api's instead
// Ideally we'd fail hard on those, but not all plugins are properly converted yet, and some
// libraries try to require them for feature detection (e.g. jsbase64)
if (stubModules.has(moduleName)) {
console.warn(
`Found a reference to built-in module '${moduleName}', which will be stubbed out. Referer: ${context.originModulePath}`,