From eb4de1f3b7d75178dd14224325f7716ea5667842 Mon Sep 17 00:00:00 2001 From: suyimo <2279277085@qq.com> Date: Tue, 18 Jun 2019 03:53:47 -0700 Subject: [PATCH] Add protect when save task (#466) Summary: Bugfix Add protect when save task If local cache resource are valid, we don't create a Task .So here are crash. Pull Request resolved: https://github.com/facebook/flipper/pull/466 Reviewed By: passy Differential Revision: D15851816 Pulled By: priteshrnandgaonkar fbshipit-source-id: 753b3c5c9a6ed4c703c934a89e45fa30df99068c --- .../SKIOSNetworkPlugin/FLEXNetworkLib/FLEXNetworkObserver.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/iOS/Plugins/FlipperKitNetworkPlugin/SKIOSNetworkPlugin/FLEXNetworkLib/FLEXNetworkObserver.mm b/iOS/Plugins/FlipperKitNetworkPlugin/SKIOSNetworkPlugin/FLEXNetworkLib/FLEXNetworkObserver.mm index 723345b4b..4da1d86d0 100755 --- a/iOS/Plugins/FlipperKitNetworkPlugin/SKIOSNetworkPlugin/FLEXNetworkLib/FLEXNetworkObserver.mm +++ b/iOS/Plugins/FlipperKitNetworkPlugin/SKIOSNetworkPlugin/FLEXNetworkLib/FLEXNetworkObserver.mm @@ -847,7 +847,10 @@ static char const *const kFLEXRequestIDKey = "kFLEXRequestIDKey"; + (void)setRequestID:(NSString *)requestID forConnectionOrTask:(id)connectionOrTask { - objc_setAssociatedObject(connectionOrTask, kFLEXRequestIDKey, requestID, OBJC_ASSOCIATION_RETAIN_NONATOMIC); + if (connectionOrTask) { + objc_setAssociatedObject(connectionOrTask, kFLEXRequestIDKey, requestID, OBJC_ASSOCIATION_RETAIN_NONATOMIC); + } + } #pragma mark - Initialization