jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixing tracking metrics

Browse Source 
Summary:
- fixing dropped frames calculation
- fixing plugin activation time

Reviewed By: passy

Differential Revision: D9301759

fbshipit-source-id: 872e4d2edcafdbc67668f3d0b713dfbf55f068f5
This commit is contained in:
Daniel Büchele
2018-08-13 15:14:11 -07:00
committed by Facebook Github Bot
parent 656044ce69
commit eb316be4e4
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/PluginContainer.js
View File

@@ -108,7 +108,7 @@ class PluginContainer extends Component<Props, State> {
if (ref && target) { if (ref && target) {
activateMenuItems(ref); activateMenuItems(ref);
ref._init(); ref._init();
this.props.logger.trackTimeSince(`activePlugin-${ref.id}`); this.props.logger.trackTimeSince(`activePlugin-${ref.constructor.id}`);
this.plugin = ref; this.plugin = ref;
} }
}; };

5
src/dispatcher/tracking.js
View File

@@ -18,8 +18,9 @@ export default (store: Store, logger: Logger) => {
) { ) {
const now = performance.now(); const now = performance.now();
requestAnimationFrame(() => droppedFrameDetection(now, isWindowFocused)); requestAnimationFrame(() => droppedFrameDetection(now, isWindowFocused));
if (isWindowFocused()) { const dropped = Math.round((now - past) / (1000 / 60) - 1);
droppedFrames += Math.max(0, Math.round(now - past / (1000 / 60) - 1)); if (dropped > 0 && isWindowFocused()) {
droppedFrames += dropped;
} }
} }