Bump socket.io from 2.3.0 to 3.1.0 in /desktop (#1845)

Summary:
Bumps [socket.io](https://github.com/socketio/socket.io) from 2.3.0 to 3.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p>
<blockquote>
<h2>3.1.0</h2>
<p>In order to ease the migration to Socket.IO v3, the v3 server is now able to communicate with v2 clients:</p>
<pre lang="js"><code>const io = require(&quot;socket.io&quot;)({
  allowEIO3: true // false by default
});
</code></pre>
<p>Note: the <code>allowEIO3</code> refers to the version 3 of the Engine.IO protocol which is used in Socket.IO v2</p>
<h3>Features</h3>
<ul>
<li>confirm a weak but matching ETag (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3485">#3485</a>) (<a href="161091dd4c">161091d</a>)</li>
<li><strong>esm:</strong> export the Namespace and Socket class (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3699">#3699</a>) (<a href="233650c222">233650c</a>)</li>
<li>add support for Socket.IO v2 clients (<a href="9925746c8e">9925746</a>)</li>
<li>add room events (<a href="155fa6333a">155fa63</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>allow integers as event names (<a href="1c220ddbf4">1c220dd</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Milestone: -</li>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/3.0.5...3.1.0">https://github.com/socketio/socket.io/compare/3.0.5...3.1.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/3.1.0">3.1.0</a></li>
<li>engine.io version:  <code>~4.1.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
<h2>3.0.5</h2>
<h3>Bug Fixes</h3>
<ul>
<li>properly clear timeout on connection failure (<a href="170b739f14">170b739</a>)</li>
</ul>
<h3>Reverts</h3>
<ul>
<li>restore the socket middleware functionality (<a href="bf54327421">bf54327</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Milestone: -</li>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/3.0.4...3.0.5">https://github.com/socketio/socket.io/compare/3.0.4...3.0.5</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/3.0.5">3.0.5</a></li>
<li>engine.io version:  <code>~4.0.6</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md">socket.io's changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/socketio/socket.io/compare/3.0.5...3.1.0">3.1.0</a> (2021-01-15)</h1>
<h3>Features</h3>
<ul>
<li>confirm a weak but matching ETag (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3485">#3485</a>) (<a href="161091dd4c">161091d</a>)</li>
<li><strong>esm:</strong> export the Namespace and Socket class (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3699">#3699</a>) (<a href="233650c222">233650c</a>)</li>
<li>add support for Socket.IO v2 clients (<a href="9925746c8e">9925746</a>)</li>
<li>add room events (<a href="155fa6333a">155fa63</a>)</li>
</ul>
<h3>Bug Fixes</h3>
<ul>
<li>allow integers as event names (<a href="1c220ddbf4">1c220dd</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/3.0.4...3.0.5">3.0.5</a> (2021-01-05)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>properly clear timeout on connection failure (<a href="170b739f14">170b739</a>)</li>
</ul>
<h3>Reverts</h3>
<ul>
<li>restore the socket middleware functionality (<a href="bf54327421">bf54327</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/3.0.3...3.0.4">3.0.4</a> (2020-12-07)</h2>
<h2><a href="https://github.com/socketio/socket.io/compare/3.0.2...3.0.3">3.0.3</a> (2020-11-19)</h2>
<h2><a href="https://github.com/socketio/socket.io/compare/3.0.1...3.0.2">3.0.2</a> (2020-11-17)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>merge Engine.IO options (<a href="43705d7a91">43705d7</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/3.0.0...3.0.1">3.0.1</a> (2020-11-09)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>export ServerOptions and Namespace types (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3684">#3684</a>) (<a href="f62f180eda">f62f180</a>)</li>
<li><strong>typings:</strong> update the signature of the emit method (<a href="50671d984a">50671d9</a>)</li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="f05a4a6f82"><code>f05a4a6</code></a> chore(release): 3.1.0</li>
<li><a href="2c883f5d4e"><code>2c883f5</code></a> chore: bump socket.io-adapter version</li>
<li><a href="161091dd4c"><code>161091d</code></a> feat: confirm a weak but matching ETag (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3485">#3485</a>)</li>
<li><a href="d52532b7be"><code>d52532b</code></a> docs: add other client implementations (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3593">#3593</a>)</li>
<li><a href="6b1d7901db"><code>6b1d790</code></a> docs(examples): Improve the chat example with more ES6 features (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3240">#3240</a>)</li>
<li><a href="b55892ae80"><code>b55892a</code></a> docs: add run on repl.it badge to README (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3617">#3617</a>)</li>
<li><a href="233650c222"><code>233650c</code></a> feat(esm): export the Namespace and Socket class (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3699">#3699</a>)</li>
<li><a href="9925746c8e"><code>9925746</code></a> feat: add support for Socket.IO v2 clients</li>
<li><a href="de8dffd252"><code>de8dffd</code></a> refactor: strict type check in if expressions (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3744">#3744</a>)</li>
<li><a href="f8a66fd11a"><code>f8a66fd</code></a> chore(release): 3.0.5</li>
<li>Additional commits viewable in <a href="https://github.com/socketio/socket.io/compare/2.3.0...3.1.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=2.3.0&new-version=3.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/1845

Reviewed By: mweststrate

Differential Revision: D25945568

Pulled By: priteshrnandgaonkar

fbshipit-source-id: 31e4955729b2ce16de88243e9520429f59922d58

desktop/scripts/start-dev-server.ts

@@ -290,10 +290,10 @@ function startAssetServer(
 }
 
 async function addWebsocket(server: http.Server) {
-  const io = socketIo(server);
+  const io = require('socket.io')(server); // 3.1.0 socket.io doesn't have type definitions
 
   // notify connected clients that there's errors in the console
-  io.on('connection', (client) => {
+  io.on('connection', (client: any) => {
     if (hasErrors()) {
       client.emit('hasErrors', ansiToHtmlConverter.toHtml(buildErrorScreen()));
     }