From ea1c21c8c312f9ed21635563385fe31409ee45ec Mon Sep 17 00:00:00 2001
From: Michel Weststrate <mweststrate@fb.com>
Date: Thu, 20 Feb 2020 04:37:53 -0800
Subject: [PATCH] Fix key warnings

Summary: Fixed a bunch of key errors in the network plugin, when a plugin is selected

Reviewed By: passy

Differential Revision: D19980275

fbshipit-source-id: 0ae61ed3b655c03d11c848d3502f455a409dcdcf
---
 src/plugins/network/RequestDetails.tsx | 67 +++++++++++++++++---------
 1 file changed, 43 insertions(+), 24 deletions(-)

diff --git a/src/plugins/network/RequestDetails.tsx b/src/plugins/network/RequestDetails.tsx
index 573e19399..2284f7521 100644
--- a/src/plugins/network/RequestDetails.tsx
+++ b/src/plugins/network/RequestDetails.tsx
@@ -132,7 +132,11 @@ export default class RequestDetails extends Component<
 
     return (
       <RequestDetails.Container>
-        <Panel heading={'Request'} floating={false} padded={false}>
+        <Panel
+          key="request"
+          heading={'Request'}
+          floating={false}
+          padded={false}>
           <ManagedTable
             multiline={true}
             columnSizes={KeyValueColumnSizes}
@@ -154,13 +158,18 @@ export default class RequestDetails extends Component<
         ) : null}
 
         {request.headers.length > 0 ? (
-          <Panel heading={'Request Headers'} floating={false} padded={false}>
+          <Panel
+            key="headers"
+            heading={'Request Headers'}
+            floating={false}
+            padded={false}>
             <HeaderInspector headers={request.headers} />
           </Panel>
         ) : null}
 
         {request.data != null ? (
           <Panel
+            key="requestData"
             heading={'Request Body'}
             floating={false}
             padded={!formattedText}>
@@ -170,29 +179,35 @@ export default class RequestDetails extends Component<
             />
           </Panel>
         ) : null}
-        {response
-          ? [
-              response.headers.length > 0 ? (
-                <Panel
-                  heading={'Response Headers'}
-                  floating={false}
-                  padded={false}>
-                  <HeaderInspector headers={response.headers} />
-                </Panel>
-              ) : null,
+        {response ? (
+          <>
+            {response.headers.length > 0 ? (
               <Panel
-                heading={'Response Body'}
+                key={'responseheaders'}
+                heading={'Response Headers'}
                 floating={false}
-                padded={!formattedText}>
-                <ResponseBodyInspector
-                  formattedText={formattedText}
-                  request={request}
-                  response={response}
-                />
-              </Panel>,
-            ]
-          : null}
-        <Panel heading={'Options'} floating={false} collapsed={true}>
+                padded={false}>
+                <HeaderInspector headers={response.headers} />
+              </Panel>
+            ) : null}
+            <Panel
+              key={'responsebody'}
+              heading={'Response Body'}
+              floating={false}
+              padded={!formattedText}>
+              <ResponseBodyInspector
+                formattedText={formattedText}
+                request={request}
+                response={response}
+              />
+            </Panel>
+          </>
+        ) : null}
+        <Panel
+          key="options"
+          heading={'Options'}
+          floating={false}
+          collapsed={true}>
           <Select
             grow
             label="Body"
@@ -202,7 +217,11 @@ export default class RequestDetails extends Component<
           />
         </Panel>
         {response && response.insights ? (
-          <Panel heading={'Insights'} floating={false} collapsed={true}>
+          <Panel
+            key="insights"
+            heading={'Insights'}
+            floating={false}
+            collapsed={true}>
             <InsightsInspector insights={response.insights} />
           </Panel>
         ) : null}