comments and variable names
Summary: renaming across the app: - comments - variable names - constants Reviewed By: passy Differential Revision: D9861792 fbshipit-source-id: 72dea05d1427b1dc0f54a7865cc0ecffd69bdb27
This commit is contained in:
committed by
Facebook Github Bot
parent
df0a0da744
commit
e9490ca3b4
@@ -54,14 +54,14 @@ export type SecureServerConfig = {|
|
||||
|
||||
/*
|
||||
* This class is responsible for generating and deploying server and client
|
||||
* certificates to allow for secure communication between sonar and apps.
|
||||
* certificates to allow for secure communication between Flipper and apps.
|
||||
* It takes a Certificate Signing Request which was generated by the app,
|
||||
* using the app's public/private keypair.
|
||||
* With this CSR it uses the sonar CA to sign a client certificate which it
|
||||
* With this CSR it uses the Flipper CA to sign a client certificate which it
|
||||
* deploys securely to the app.
|
||||
* It also deploys the sonar CA cert to the app.
|
||||
* It also deploys the Flipper CA cert to the app.
|
||||
* The app can trust a server if and only if it has a certificate signed by the
|
||||
* sonar CA.
|
||||
* Flipper CA.
|
||||
*/
|
||||
export default class CertificateProvider {
|
||||
logger: LogManager;
|
||||
@@ -310,14 +310,14 @@ export default class CertificateProvider {
|
||||
.then(output => {
|
||||
if (output.match(appNotDebuggableRegex)) {
|
||||
const e = new RecurringError(
|
||||
`Android app ${user} is not debuggable. To use it with sonar, add android:debuggable="true" to the application section of AndroidManifest.xml`,
|
||||
`Android app ${user} is not debuggable. To use it with Flipper, add android:debuggable="true" to the application section of AndroidManifest.xml`,
|
||||
);
|
||||
this.server.emit('error', e);
|
||||
throw e;
|
||||
}
|
||||
if (output.toLowerCase().match(operationNotPermittedRegex)) {
|
||||
const e = new RecurringError(
|
||||
`Your android device (${deviceId}) does not support the adb shell run-as command. We're tracking this at https://github.com/facebook/Sonar/issues/92`,
|
||||
`Your android device (${deviceId}) does not support the adb shell run-as command. We're tracking this at https://github.com/facebook/flipper/issues/92`,
|
||||
);
|
||||
this.server.emit('error', e);
|
||||
throw e;
|
||||
|
||||
Reference in New Issue
Block a user