Limit the size of the containers and make it scrollable
Summary: Improves the UI of crash reporter plugin - Added max height on the value container with scrollable capabilities - Fixed the bug in UI of the plugin where it showed the latest crash data even though one navigated to the plugin from old crash notification Reviewed By: danielbuechele Differential Revision: D13307302 fbshipit-source-id: 97eb96d3d9947a2835cd5572053256e0bdc01e27
This commit is contained in:
committed by
Facebook Github Bot
parent
9cfa1b3074
commit
e84e859fc1
@@ -294,7 +294,14 @@ export default class LogTable extends FlipperDevicePlugin<
|
||||
if (!matched) {
|
||||
return matched;
|
||||
}
|
||||
for (let i = 0; i < crash.callStack.length && matched; ++i) {
|
||||
// If top 10 callstack entries are present in a row then it most probably matches the row.
|
||||
// The reason why we do not perform the full callstack check is that sometimes the row in logs plugins has truncated data
|
||||
// TODO: T37573722
|
||||
for (
|
||||
let i = 0;
|
||||
i < Math.min(crash.callStack.length, 10) && matched;
|
||||
++i
|
||||
) {
|
||||
//$FlowFixMe: x.filterValue is not undefined
|
||||
matched = x.filterValue.includes(crash.callStack[i]);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user