Move flipper plugin from flipper-lib types to flipper-common

Summary: Moved all types related to plugin descriptions from plugin-lib (which handles downloads and such) to flipper-common. The goal of that is to remove all plugin-lib usage from ui-core to server-core, so that the UI itself doesn't do any file operations anymore related to plugins. That will be done in next diffs, this just moves types but no code.

Reviewed By: nikoant, aigoncharov

Differential Revision: D32665064

fbshipit-source-id: 86d908e7264569b0229b09290a891171876c8e00

desktop/flipper-ui-core/src/dispatcher/__tests__/plugins.node.tsx

@@ -16,7 +16,7 @@ import dispatcher, {
   createRequirePluginFunction,
   getLatestCompatibleVersionOfEachPlugin,
 } from '../plugins';
-import {BundledPluginDetails, InstalledPluginDetails} from 'flipper-plugin-lib';
+import {BundledPluginDetails, InstalledPluginDetails} from 'flipper-common';
 import path from 'path';
 import {createRootReducer, State} from '../../reducers/index';
 import {getLogger} from 'flipper-common';

desktop/flipper-ui-core/src/dispatcher/pluginDownloads.tsx

@@ -8,12 +8,14 @@
  */
 
 import {
-  DownloadablePluginDetails,
   getInstalledPluginDetails,
   getPluginVersionInstallationDir,
-  InstalledPluginDetails,
   installPluginFromFile,
 } from 'flipper-plugin-lib';
+import {
+  InstalledPluginDetails,
+  DownloadablePluginDetails,
+} from 'flipper-common';
 import {State, Store} from '../reducers/index';
 import {
   PluginDownloadStatus,

desktop/flipper-ui-core/src/dispatcher/pluginManager.tsx

@@ -8,7 +8,7 @@
  */
 
 import type {Store} from '../reducers/index';
-import type {Logger} from 'flipper-common';
+import type {Logger, ActivatablePluginDetails} from 'flipper-common';
 import {
   LoadPluginActionPayload,
   UninstallPluginActionPayload,
@@ -21,7 +21,6 @@ import {
   getInstalledPlugins,
   cleanupOldInstalledPluginVersions,
   removePlugins,
-  ActivatablePluginDetails,
 } from 'flipper-plugin-lib';
 import {sideEffect} from '../utils/sideEffect';
 import {requirePlugin} from './plugins';

desktop/flipper-ui-core/src/dispatcher/plugins.tsx

@@ -32,7 +32,7 @@ import {
   ActivatablePluginDetails,
   BundledPluginDetails,
   ConcretePluginDetails,
-} from 'flipper-plugin-lib';
+} from 'flipper-common';
 import {tryCatchReportPluginFailures, reportUsage} from 'flipper-common';
 import * as FlipperPluginSDK from 'flipper-plugin';
 import {_SandyPluginDefinition} from 'flipper-plugin';