jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix exception initial databaseList request failed: T.sort is not a function

Browse Source 
Summary: Exception showed up in our monitoring. The only `.sort` that happens in that request/response sequence is the one updated. Didn't get to the root of this, but likely the plugin returns nothing rather than an empty array when no databases present?

Reviewed By: LukeDefeo

Differential Revision: D47665268

fbshipit-source-id: 3f8dea591db3e6cb5d4e0d09f893a177ad4f642e
This commit is contained in:
Michel Weststrate
2023-07-24 07:46:34 -07:00
committed by Facebook GitHub Bot
parent 6048f09fd0
commit e7ac579d1c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/plugins/public/databases/index.tsx
View File

@@ -108,7 +108,7 @@ export function plugin(client: PluginClient<Events, Methods>) {
const updateDatabases = (event: { const updateDatabases = (event: {
databases: Array<{name: string; id: number; tables: Array<string>}>; databases: Array<{name: string; id: number; tables: Array<string>}>;
}) => { }) => {
const updates = event.databases; const updates = event.databases ?? [];
const state = pluginState.get(); const state = pluginState.get();
const databases = updates.sort((db1, db2) => db1.id - db2.id); const databases = updates.sort((db1, db2) => db1.id - db2.id);
const selectedDatabase = const selectedDatabase =