From e7806d5be75b66ddf2b3a0a98f0a2fac0609cf92 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Fri, 26 May 2023 08:02:12 -0700 Subject: [PATCH] Track server start Summary: Need to answer: - How many starts a day over time Reviewed By: antonk52 Differential Revision: D46219995 fbshipit-source-id: bffaeadf684a2d34c6e145784c5a86dbaf5f532a --- desktop/flipper-server-core/src/server/startServer.tsx | 6 ++++-- desktop/flipper-server-core/src/utils/tracker.tsx | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/desktop/flipper-server-core/src/server/startServer.tsx b/desktop/flipper-server-core/src/server/startServer.tsx index 795afeb44..c8e8ce7aa 100644 --- a/desktop/flipper-server-core/src/server/startServer.tsx +++ b/desktop/flipper-server-core/src/server/startServer.tsx @@ -224,8 +224,10 @@ async function startProxyServer( return new Promise((resolve) => { proxyServer?.listen(config.port); server.listen(socketPath, undefined, () => resolve()); - - // TODO: track server has started at this stage. + tracker.track('server-started', { + port: config.port, + tcp: config.tcp, + }); }); }; resolve({app, server, socket, readyForIncomingConnections}); diff --git a/desktop/flipper-server-core/src/utils/tracker.tsx b/desktop/flipper-server-core/src/utils/tracker.tsx index 621f7cde1..7f4cbf6fe 100644 --- a/desktop/flipper-server-core/src/utils/tracker.tsx +++ b/desktop/flipper-server-core/src/utils/tracker.tsx @@ -10,6 +10,7 @@ import {getLogger} from 'flipper-common'; type TrackerEvents = { + 'server-started': {port: number; tcp: boolean}; 'server-auth-token-verification': { successful: boolean; present: boolean;