Move keychain storage to server, some constants cleanup

Summary: This diff moves keychain storage to the server. Figured to leave request logic itself in the UI-core, as basically all use cases happen there, except for streaming download for mobile build plugin, so sending the requests from the backend doesn't really seem to add value, unless we run into some CORS issues later.

Reviewed By: passy

Differential Revision: D32596715

fbshipit-source-id: f5ab9d794f91a6eb8a8dc07ae723bf2890726771

desktop/app/src/init.tsx

@@ -26,7 +26,7 @@ import {
   loadSettings,
   setupPrefetcher,
 } from 'flipper-server-core';
-import {getLogger, Logger, setLoggerInstance} from 'flipper-common';
+import {getLogger, isTest, Logger, setLoggerInstance} from 'flipper-common';
 import constants from './fb-stubs/constants';
 import {initializeElectron} from './electron/initializeElectron';
 import path from 'path';
@@ -54,19 +54,31 @@ if (process.env.NODE_ENV === 'development' && os.platform() === 'darwin') {
 async function start() {
   const app = remote.app;
   const execPath = process.execPath || remote.process.execPath;
+  const appPath = app.getAppPath();
   const isProduction = !/node_modules[\\/]electron[\\/]/.test(execPath);
   const env = process.env;
 
   const logger = createDelegatedLogger();
   setLoggerInstance(logger);
 
+  let keytar: any = undefined;
+  try {
+    if (!isTest()) {
+      keytar = (global.electronRequire || require)(
+        path.join(appPath, 'native-modules', `keytar-${process.platform}.node`),
+      );
+    }
+  } catch (e) {
+    console.error('Failed to load keytar:', e);
+  }
+
   const flipperServer = new FlipperServerImpl(
     {
       env,
       gatekeepers: getGatekeepers(),
       isProduction,
       paths: {
-        appPath: app.getAppPath(),
+        appPath,
         homePath: app.getPath('home'),
         execPath,
         staticPath: getStaticDir(),
@@ -79,12 +91,13 @@ async function start() {
       validWebSocketOrigins: constants.VALID_WEB_SOCKET_REQUEST_ORIGIN_PREFIXES,
     },
     logger,
+    keytar,
   );
 
   await flipperServer.connect();
   const flipperServerConfig = await flipperServer.exec('get-config');
 
-  initializeElectron(flipperServerConfig);
+  initializeElectron(flipperServer, flipperServerConfig);
 
   // By turning this in a require, we force the JS that the body of this module (init) has completed (initializeElectron),
   // before starting the rest of the Flipper process.